Merge lp:~joetalbott/utah/fix_fetch_revision into lp:utah

[Joe Talbott]

Don't allow a failed remote 'bzr revno' to halt testsuite execution.

Don't allow a failed remote 'bzr revno' to halt testsuite execution.

[Javier Collado (javier.collado)]

I tried to run the code in this branch and was able to reproduce the problem it
adresses (it seems that launchpad issues are not uncommon).

The report I obtained, was like this:
...
- cmd_type: testsuite_fetch
  command: bzr revno lp:utah/utah/client/examples/utah_tests_sample
  returncode: 3
  start_time: '2013-02-13 17:49:10'
  stderr: |-
    You have not informed bzr of your Launchpad ID, and you must do this to
    write to Launchpad or access private data. See "bzr help launchpad-login".
    bzr: ERROR: Invalid http response for http://bazaar.launchpad.net/~utah/utah/dev/utah/client/.bzr/branch-format: Unable to handle http code 502: Bad Gateway
  stdout: ''
  time_delta: '0:00:02.631339'
  user: root
...
errors: 0
failures: 0
fetch_errors: 1
...
passes: 1
...

However, the return code was '255' instead of '0' which I believe should have
been the correct value given that all test cases passed.

review: Needs Fixing

[lp:~joetalbott/utah/fix_fetch_revision]

816. By Joe Talbott on 2013-02-13

Don't increment fetch_errors if revision command fails.

[Joe Talbott (joetalbott)]

Updated to not increment fetch_errors.

review: Needs Resubmitting

[Javier Collado (javier.collado)]

This time I was just able to simulate the problem changing the commands in
common.py, but that was enough to make sure that the return code was '0' and
the number of passes was correct.

review: Approve

=== modified file 'utah/client/runner.py'
--- utah/client/runner.py	2013-02-11 17:18:56 +0000
+++ utah/client/runner.py	2013-02-13 19:39:22 +0000
@@ -475,6 +475,11 @@
                 res = vcs_handler.revision(directory=rev_dir)
                 self.result.add_result(res)
 
+                # If we're unable to get the revision number indicate a
+                # fetch failure but allow the test runs to proceed.
+                if self.result.status != 'PASS':
+                    self.result.status = 'PASS'
+
                 self.fetched_suites.append(name)
 
                 # Create a TestSuite