Merge lp:~joetalbott/utah/fix_duplicate_docstrings into lp:utah

Proposed by Joe Talbott
Status: Merged
Approved by: Javier Collado
Approved revision: 783
Merged at revision: 785
Proposed branch: lp:~joetalbott/utah/fix_duplicate_docstrings
Merge into: lp:utah
Diff against target: 21 lines (+2/-2)
1 file modified
utah/client/tests/test_state_agent.py (+2/-2)
To merge this branch: bzr merge lp:~joetalbott/utah/fix_duplicate_docstrings
Reviewer Review Type Date Requested Status
Javier Collado (community) Approve
Joe Talbott (community) Needs Resubmitting
Review via email: mp+139212@code.launchpad.net

Description of the change

This branch fixes the docstrings that were duplicated in some testcases.

To post a comment you must log in.
Revision history for this message
Javier Collado (javier.collado) wrote :

When looking at a failure in nosetests output, if the method contains a
docstring, it prints the first line as an id of the test case:

======================================================================
ERROR: Test that a partially run state file with all jobs done
----------------------------------------------------------------------

Hence, if the first line is in the docstring is still the same one, the problem
isn't fixed. To be more specific, the test cases involved are:

test_load_state_partial
test_load_state_partial_run_all
test_load_state_partial_done_all_failed

review: Needs Fixing
783. By Joe Talbott

test_state_agent - Shorten docstrings and make them unique.

Revision history for this message
Joe Talbott (joetalbott) wrote :

I didn't realize it only uses the first line. This is actually one thing I don't like about nosetests. I've shortened the docstrings back to a single unique line.

review: Needs Resubmitting
Revision history for this message
Javier Collado (javier.collado) wrote :

Thanks for the update.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utah/client/tests/test_state_agent.py'
2--- utah/client/tests/test_state_agent.py 2012-12-11 09:47:51 +0000
3+++ utah/client/tests/test_state_agent.py 2012-12-11 16:56:20 +0000
4@@ -153,7 +153,7 @@
5
6 def test_load_state_partial_run_all(self):
7 """
8- Test that a partially run state file can be resumed.
9+ Test partially run state file - run all jobs.
10 """
11 fp = open(self.state_file, 'w')
12 fp.write(self.partial_state_file_content_run_all)
13@@ -198,7 +198,7 @@
14
15 def test_load_state_partial_done_all_failed(self):
16 """
17- Test that a partially run state file can be resumed.
18+ Test partially run state file - all jobs failed.
19 """
20 fp = open(self.state_file, 'w')
21 fp.write(self.partial_state_file_content_done_all_failed)

Subscribers

People subscribed via source and target branches