Merge lp:~joetalbott/ci-core-jenkins/fix_names into lp:ci-core-jenkins

Proposed by Joe Talbott
Status: Merged
Approved by: Joe Talbott
Approved revision: 17
Merged at revision: 16
Proposed branch: lp:~joetalbott/ci-core-jenkins/fix_names
Merge into: lp:ci-core-jenkins
Diff against target: 34 lines (+9/-8)
1 file modified
workers/fetch_latest_results/__init__.py (+9/-8)
To merge this branch: bzr merge lp:~joetalbott/ci-core-jenkins/fix_names
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Para Siva (community) Approve
Review via email: mp+262636@code.launchpad.net

Commit message

Make container and result file names match what lp:autopkgtest-result-checker produces.

Description of the change

Make container and result file names match what lp:autopkgtest-result-checker produces.

To post a comment you must log in.
Revision history for this message
Para Siva (psivaa) wrote :

Seems ok to me, not being able to test this though.

review: Approve
Revision history for this message
Para Siva (psivaa) wrote :

This also needs the AUTH url change in the config file. I already had an MP for this in-progress for the channel, release name fixes to land. https://code.launchpad.net/~psivaa/ci-core-jenkins/ps4.5-auth-url/+merge/261357

Revision history for this message
Francis Ginther (fginther) wrote :

Argh, I missed this in my earlier review, there is no "args.release" being parsed. I'm not opposed to setting this with a default value of "rolling" and limiting the amount of code changes.

review: Needs Fixing
17. By Joe Talbott

Hardcode "rolling" for the release for now.

Revision history for this message
Francis Ginther (fginther) wrote :

should be good to go, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'workers/fetch_latest_results/__init__.py'
2--- workers/fetch_latest_results/__init__.py 2015-06-04 15:15:57 +0000
3+++ workers/fetch_latest_results/__init__.py 2015-06-23 18:17:19 +0000
4@@ -31,7 +31,7 @@
5 logger = logging.getLogger(__name__)
6
7 RESULT_FILE = os.path.join(os.path.dirname(__file__),
8- '../../ubuntu-core_{}-{}-{}-results.tgz')
9+ '../../{}-results.tgz')
10 DESTINATION_RESULT_DIR = os.path.join(os.path.dirname(__file__),
11 '../../results')
12
13@@ -97,13 +97,14 @@
14 result_url = config.get(args.channel, 'result_url')
15 retry_count = int(config.get(args.channel, 'retry_count'))
16
17- url = "{0}/core-ubuntu-core_{1}-{2}-{3}/"\
18- "core-ubuntu-core_{1}-{2}-{3}-results.tgz"
19- url = url.format(result_url,
20- args.channel,
21- args.device,
22- args.image_id)
23- result_file = RESULT_FILE.format(args.channel, args.device, args.image_id)
24+ container_name = "core-{}-{}-{}-{}".format(
25+ 'rolling',
26+ args.channel,
27+ args.device,
28+ args.image_id)
29+ url = "{0}/{1}/{1}-results.tgz"
30+ url = url.format(result_url, container_name)
31+ result_file = RESULT_FILE.format(container_name)
32 _clean_old_results()
33
34 count = 0

Subscribers

People subscribed via source and target branches