Merge lp:~joetalbott/adt-cloud-worker/user_docs into lp:adt-cloud-worker
Proposed by
Joe Talbott
Status: | Merged |
---|---|
Approved by: | Joe Talbott |
Approved revision: | 47 |
Merged at revision: | 44 |
Proposed branch: | lp:~joetalbott/adt-cloud-worker/user_docs |
Merge into: | lp:adt-cloud-worker |
Diff against target: |
69 lines (+65/-0) 1 file modified
README-run-locally.rst (+65/-0) |
To merge this branch: | bzr merge lp:~joetalbott/adt-cloud-worker/user_docs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joe Talbott (community) | Approve | ||
Para Siva (community) | Approve | ||
Francis Ginther | Approve | ||
Celso Providelo (community) | Approve | ||
Review via email: mp+257833@code.launchpad.net |
Commit message
Add documentation for running tests locally like CI does.
Description of the change
Add documentation for running tests locally like CI does.
To post a comment you must log in.
A few thoughts, which are only mild suggestions, feel free to ignore:
* I wonder if this is the best place for the docs?
* I suggest that the default documented command should be sans '-d' options, with a note that they can be added to increase the verbosity.
* The $PROXY env var isn't documented anywhere.
* What happens when we bump the timeout values we use in the service itself?
As an alternative approach, since the devs have the branch locally to be reading the docs, how about suggesting that they run something like:
python3 -c "import adt_cloud_worker; adt_cloud_ worker. run_test( package= 'linux' , result_ dirt='/ tmp/results' ...)"
We can re-arrange the code to make that easier. Since one of the acceptance criteria is that the tests must be repeatable locally, this seems like it would be within the scope of the sprint, and would upgrade the 'connasence of value' too 'connasence of name' instead, which is an improvment.
Thoughts?