Merge lp:~joetalbott/adt-cloud-service/check_trailing_slash into lp:adt-cloud-service

Proposed by Joe Talbott
Status: Merged
Approved by: Celso Providelo
Approved revision: 27
Merged at revision: 24
Proposed branch: lp:~joetalbott/adt-cloud-service/check_trailing_slash
Merge into: lp:adt-cloud-service
Diff against target: 21 lines (+4/-3)
1 file modified
adt_cloud_service/v1.py (+4/-3)
To merge this branch: bzr merge lp:~joetalbott/adt-cloud-service/check_trailing_slash
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Review via email: mp+256532@code.launchpad.net

Commit message

Ensure there's a trailing slash on swift urls before appending to them.

Description of the change

Ensure there's a trailing slash on swift urls before appending to them.

To post a comment you must log in.
25. By Joe Talbott

Make trailing slash check a bit more readable.

26. By Joe Talbott

Make trailing slash checking even easier to read.

27. By Joe Talbott

Even more better.

Revision history for this message
Celso Providelo (cprov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'adt_cloud_service/v1.py'
2--- adt_cloud_service/v1.py 2015-04-15 16:55:51 +0000
3+++ adt_cloud_service/v1.py 2015-04-16 18:36:46 +0000
4@@ -60,13 +60,14 @@
5
6 req_id = current_app.extensions['rabbit'].queue_test(rabbit_request)
7 results_path = 'adt-{}/results.tgz'.format(req_id)
8+ swift_url = current_app.config['SWIFT_URL']
9+ if swift_url.endswith('/'):
10+ swift_url += "/"
11 return jsonify(
12 {
13 'status': 'request processed',
14 'request_id': req_id,
15- 'result_url': urllib.parse.urljoin(
16- current_app.config['SWIFT_URL'], results_path
17- )
18+ 'result_url': urllib.parse.urljoin(swift_url, results_path)
19 }
20 )
21 return repr(request.form)

Subscribers

People subscribed via source and target branches