Merge lp:~joerlend.schinstad-deactivatedaccount/quidgets/main into lp:quidgets

[Jo-Erlend Schinstad]

A very, very minor, but important fix.

I had a regression in the fix that made it possible to set the grid editable without resetting the grid. I had simply looped over each column, calling .set_property("editable", editable) on each. The problem is that gtk.CellRendererText doesn't support that property, so I had to fix it. It's a much better solution in any case, since we're now able to set a column editable directly by just calling column.set_editable(editable) (CheckColumn will be sett activatable).

So this fixes https://bugs.launchpad.net/quidgets/+bug/841357

[Rick Spencer (rick-rickspencer3)]

I like the way you fixed the issue. I added a test that failed before the fix is applied and passes after the fix is applied. I like to do this with each bug fix as it helps catch regressions during future development and bug fixing.

review: Approve

=== modified file 'quickly/widgets/dictionary_grid.py'
--- quickly/widgets/dictionary_grid.py	2011-08-19 17:22:14 +0000
+++ quickly/widgets/dictionary_grid.py	2011-09-05 00:10:26 +0000
@@ -193,7 +193,7 @@
         # themselves, but for now this works. 
 
         for column in self.get_columns():
-		    column.renderer.set_property("editable", editable)
+		    column.set_editable(editable)
         self._editable = editable
 
     @property

=== modified file 'quickly/widgets/grid_column.py'
--- quickly/widgets/grid_column.py	2011-08-19 17:22:14 +0000
+++ quickly/widgets/grid_column.py	2011-09-05 00:10:26 +0000
@@ -151,6 +151,8 @@
 
         self.list_store.reorder([r[-1] for r in rows])
 
+    def set_editable(self, editable):
+        self.renderer.set_property("editable", editable)
 
 class StringColumn( GridColumn ):
 
@@ -712,6 +714,9 @@
             dictionary = self.list_store.get_value(iter,self.dictionary_index)
             dictionary[self.key] = new_val
 
+    def set_editable(self, editable):
+        self.renderer.set_property("activatable", editable)
+
     def display_val(self, val):
         """display_val - takes a real value and returns the cooresponding
         display value