Merge lp:~joergberroth/unav/format_fixes_PoiListpage into lp:unav

Proposed by JkB
Status: Superseded
Proposed branch: lp:~joergberroth/unav/format_fixes_PoiListpage
Merge into: lp:unav
Prerequisite: lp:~joergberroth/unav/revamp_Coordinates_PageHeader
Diff against target: 12 lines (+1/-1)
1 file modified
qml/PoiListPage.qml (+1/-1)
To merge this branch: bzr merge lp:~joergberroth/unav/format_fixes_PoiListpage
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan Approve
Review via email: mp+290817@code.launchpad.net

This proposal has been superseded by a proposal from 2016-04-03.

Commit message

*from trailing to last

Description of the change

small format fixes for icon in PoiListpage

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

I'm a tiny bit confused. When I open https://code.launchpad.net/~joergberroth/unav/revamp_Coordinates_PageHeader/+merge/290814, it says the prerequisite branch is this MP.

And on this MP, it says https://code.launchpad.net/~joergberroth/unav/revamp_Coordinates_PageHeader/+merge/290814 is prerequisite. Which is which ;) ?

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

LGTM!

review: Approve
Revision history for this message
JkB (joergberroth) wrote :

ups ;-)

Am 2016-04-03 um 13:36 schrieb Nekhelesh Ramananthan:
> I'm a tiny bit confused. When I open https://code.launchpad.net/~joergberroth/unav/revamp_Coordinates_PageHeader/+merge/290814, it says the prerequisite branch is this MP.
>
> And on this MP, it says https://code.launchpad.net/~joergberroth/unav/revamp_Coordinates_PageHeader/+merge/290814 is prerequisite. Which is which ;) ?
>

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/PoiListPage.qml'
2--- qml/PoiListPage.qml 2016-04-03 11:29:53 +0000
3+++ qml/PoiListPage.qml 2016-04-03 11:29:53 +0000
4@@ -335,7 +335,7 @@
5 name: "preferences-desktop-accessibility-symbolic"
6 visible: model.wheelchair === "yes" || model.wheelchair === "limited" // is limited enough as criteria?
7 width: units.gu(2)
8- SlotsLayout.position: SlotsLayout.Trailling
9+ SlotsLayout.position: SlotsLayout.Last
10 }
11 }
12 }

Subscribers

People subscribed via source and target branches