Am 2015-06-26 um 13:51 schrieb Jonas G. Drange:
> On 26 June 2015 at 08:04, JkB <email address hidden> wrote:

> ​If that works for you, let's assume that connection.type 'wifi' is valid,
> even though it's not documented.

Yes. And you'll see also for [wifi-security] one changed that from
[802-11-wireless-security]...

> 
> Also, I added a hint in the dialog, that connecting to a network with
>> choosing a cert is more secure.
>>
> 
> Okay, but we need to make sure design is involved, so if there's nothing in
> the spec [1] about this, we have to create a bug against System Settings
> which affects ubuntu-ux. What's the basis for this hint?​
You're right. I will comment it until than.
The idea behind this is, that without certification, the user can not be
sure that he is connecting to a real e.g. "eduroam" which could be a
security problem.
On the other side it's not up to the user to fix that but to the admin
that owns the network.
So, difficult.

> 
>>>> And than there are two more points:
>>>> the peap-label check and the version check.
>>
>> I commited a fix against that. It would be great if you could test this
>> again.
> 
> 
> ​Will do! I see that the nm-applet (Ubuntu Desktop's way of connecting to
> hidden networks) does not force phase1-peaplabel=1, however, it does
> include password-flags=1 instead of password-flags=2.​
That's right.
I removed forcing peap-label and put in an itemselector for choosing
peap-version instead as this is more common.

About password-flags: [1]
password-flags=2 is issued if the password shall not be saved.

I left the flags out if pw is to be saved. defaults to 0.


> 
> 
> ​Here's [2] the work on autopilot tests for your branch​. There are some
Will have a look at this later.
> notable changes that affects your branch, not directly related to autopilot
> tests:
> 
>    - Auth methods and protocols are no longer translated (e.g. PEAP,
>    MSCHAPv2, and so on.)

ok!

>    - Your feedback change has been reverted for the following reasons:

>       - If visibility is a problem, we should to scroll to the top of the
>       dialog. This is the pattern in other dialogs as well.
That was the point I was thinking about. It is more user friendly to
have it appear right in sight over the "command" buttons.
But, you are right, scrolling would do in a way, too.
And as the tests already depend on that I will change it back.
Maybe one can think about this later.

>    - One fixme has been re-added, but I'll take care of it. :)
I removed it, as I already translate it in the certhandler.cpp !
so if you add the translation in this file, we should remove it in the
handler. What is more common?
> 
> I need suggestions on what to test. What are other popular WPA2 enterprise
> configurations? Do you have suggestions, Joerg?
I'm not a pro in that but during the last days ;-) I read of peap and
TLS being the most common. So, the TLS config would be a point to start.

> 
> Also, anything you'd like me to test?
And as I have no auto tests, checking whether all the parameters are
sent and put in right into configuration would be great. I then would go
through all the config files created.

Really looking forward to your tests.
Thanks a lot.

Joerg

[1]
https://developer.gnome.org/libnm/stable/NMSetting.html#NMSettingSecretFlags