Code review comment for lp:~joeborg/charm-helpers/charm-helpers

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Hi Joseph, can you please add a slightly more descriptive commit message. Also you seem to have unintentionally removed traceenable from the context. With regards to my previous comment on adding a new module for openstack hardening, i meant actually adding support for an altogether new layer to the stack i.e. right now we have os/apache/ssh/mysql and I'm suggesting that we add an openstack layer. This is a somewhat non-trivial change to make but if in the long run we are planning to add more openstack-specific hardening then we should evaluate doing this. If that is not the route you want to go down then I suggest you look into finding a way to make these changes purely through config such that we can avoid having subsystem-specific code in the host module.

review: Needs Fixing

« Back to merge proposal