Merge lp:~joe.julian/trac-bzr/head-typo into lp:trac-bzr

[Joe Julian]

Fixes a typo in rev_older_than where 'len(heads)' is meant to be tested, but instead it tested 'len(s)' which raised an exception.

[Martin von Gagern (gagern)]

The fix looks good to me, will merge it shortly.

I'm somewhat surprised that I didn't encounter any problems of this kind myself yet.
What user interface operation did trigger that backtrace for you? What version of trac?

review: Approve

[Joe Julian (joe.julian)]

Revision Log. I noticed it with just setting "back to" to 1 and hitting
"Update".

Trac 0.12

On 01/07/2012 11:49 AM, Martin von Gagern wrote:
> Review: Approve
>
> The fix looks good to me, will merge it shortly.
>
> I'm somewhat surprised that I didn't encounter any problems of this kind myself yet.
> What user interface operation did trigger that backtrace for you? What version of trac?

=== modified file 'tracbzr/backend.py'
--- tracbzr/backend.py	2010-11-01 13:40:19 +0000
+++ tracbzr/backend.py	2012-01-07 10:05:26 +0000
@@ -669,7 +669,7 @@
             heads = branch2.repository.get_graph().heads(both)
         else:
             heads = both
-        if len(s) == 1:
+        if len(heads) == 1:
             return rrev2 in heads
         # Bah, unrelated revisions. Fall back to comparing timestamps.
         return (branch1.repository.get_revision(rrev1).timestamp <