Amarok

~joe-yasi/amarok/+git/amarok-git:nSoK

Last commit made on 2014-02-22

Get this branch:: git clone -b nSoK https://git.launchpad.net/~joe-yasi/amarok/+git/amarok-git

Branch merges

Branch information

Name:: nSoK

Repository:: lp:~joe-yasi/amarok/+git/amarok-git

Recent commits

85a057c... by vedant agarwala on 2014-02-22

initial code movement
modified: CMakeLists.txt
modified: dialogs/MusicBrainzTagger.cpp
modified: dialogs/MusicBrainzTagger.ui
modified: tagguessing/MusicDNSAudioDecoder.cpp
modified: tagguessing/musicbrainz/MusicDNSFinder.h

3dc3bf0... by vedant agarwala on 2013-09-21

Created the tagguessing directory containing .cpp and .h files for acoustID and base classes. Created (non-working) cmake files
This is just a skeleton for future work. Classes are not complete and code probably won't even compile.
new file: ../cmake/modules/FindLibChromaprint.cmake
modified: CMakeLists.txt
new file: tagguessing/CMakeLists.txt
new file: tagguessing/Finder.cpp
new file: tagguessing/Finder.h
new file: tagguessing/Provider.cpp
new file: tagguessing/Provider.h
new file: tagguessing/acustid/Acustidprovider.cpp
new file: tagguessing/acustid/Acustidprovider.h
new file: tagguessing/acustid/Fingerprintcalculator.cpp
new file: tagguessing/acustid/Fingerprintcalculator.h
new file: tagguessing/acustid/Webservicequeryer.cpp
new file: tagguessing/acustid/Webservicequeryer.h
new file: tagguessing/musicbrainz/CMakeLists.txt

272c6b1... by Frank Meerkötter on 2013-08-18

Bug 313504: Check validity of i18n calls

Check validity of i18n calls

    See:
    [...]
    Check validity of i18n calls [i18ncheckarg]...OOPS! 4 issues found!

src/widgets/FilenameLayoutWidget.cpp: wrong argument count, have 1 need 0 line# 93 (1)
[...]

The other issues reported in that section are false positives.
        src/playlistgenerator/constraints/Checkpoint.cpp: wrong argument count, have 0 need 1 line# 170 (1)
        src/playlistgenerator/constraints/TagMatch.cpp: wrong argument count, have 0 need 1 line# 184 (1)
        src/playlistgenerator/constraints/TagMatch.cpp: wrong argument count, have 0 need 4 line# 170 (1)
    [...]

REVIEW: 112141
BUG: 313504

9f5d7ba... by Frank Meerkötter on 2013-08-18

Bug 313504: style: prefer QString::isEmpty() over a "null compare"

style: prefer QString::isEmpty() over a "null compare"

See:
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
21. Check for compares to QString::null or QString() [nullstrcompare]...OOPS! 2 issues found!

src/dialogs/TrackOrganizer.cpp: line# 83 (1)
src/playlistgenerator/PresetModel.cpp: line# 161 (1)
[...]

REVIEW: 112140
BUG: 313504

72ad2ba... by Frank Meerkötter on 2013-08-18

Bug 313504: style: prefer QString.clear over a null-assign

style: prefer QString.clear over a null-assign

    See:
    http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
    [...]
    Check for assignments to QString::null [nullstrassign]...OOPS! 6 issues found!

        src/services/amazon/AmazonStore.cpp: line# 116 (1)
        src/dialogs/TagDialog.cpp: line# 835 (1)
        src/browsers/playlistbrowser/PlaylistBrowserCategory.cpp: line# 261 (1)
        src/core-impl/collections/db/sql/SqlMeta.cpp: line# 904,1737,1886 (3)
    [...]