~joe-yasi/amarok/+git/amarok-git:master

Last commit made on 2024-04-19
Get this branch:
git clone -b master https://git.launchpad.net/~joe-yasi/amarok/+git/amarok-git

Branch merges

Branch information

Name:
master
Repository:
lp:~joe-yasi/amarok/+git/amarok-git

Recent commits

da5c3ea... by l10n daemon script <email address hidden>

GIT_SILENT Sync po/docbooks with svn

89734fa... by Tuomas Nurmi <email address hidden>

Fix sql tests crashing at exit

ThreadInitializer destructor in MySqlStorage.cpp calls mysql_library_end() when
threadsCount is 0. However, tests delete the mysqle directory earlier, causing
mysql_library_end to crash due to the database already being deleted. Work around
by postponing the mysql directory deletion by creating temporary directory as test's
static variable.

As an interesting fact, TestSqlQueryMaker hits some ThreadWeaver-related segfault quite
often. This is also sometimes visible in some other tests, and is probably a symptom
of some real problem that might cause crashes sometimes.

77d858d... by Tuomas Nurmi <email address hidden>

Avoid leaving a locked mutex when aborting directory watching.

72eab02... by Tuomas Nurmi <email address hidden>

Update TestSqlScanManager to accept the new millisecond track lengths

fc89b6d... by Tuomas Nurmi <email address hidden>

Fix AMAROK_UTILITIES_DIR so amarokscanner can be found in tests

Used only by tests/core-impl/collections/db/sql/TestSqlScanManager.cpp; not completely
sure if necessary to use it at all, but at least make it find the scanner binary in
current build setup so tests work.

d3ec038... by l10n daemon script <email address hidden>

GIT_SILENT Sync po/docbooks with svn

c8dfe85... by Tuomas Nurmi <email address hidden>

Also use higher DPI for stop after this track marker.

9c23401... by Tuomas Nurmi <email address hidden>

Fix Wikipedia album and composer loading, add warning message option

EngineController::isStream() is broken, so just try always prettyName() for album and
composer, as the code seems to return before that anyhow if the name is empty.

The warning message was set in engine but not yet displayed in UI. Add a
Kirigami.InlineMessage for displaying it if it exists. Try to empty it when not relevant
any more, display WebEngineView only when no message set. Seemed to work ok in every
scenario I tried.

34daf9d... by Tuomas Nurmi <email address hidden>

Don't show play mode controls when in dynamic mode

They don't have any effect there.

BUG: 287055

362592b... by Tuomas Nurmi <email address hidden>

Fix wikipedia applet redirections and make busyindicator more visible