kwallethelper : lp:~joe-yasi/amarok/+git/amarok-git : Git : Code : Amarok

Get this branch:: git clone -b kwallethelper https://git.launchpad.net/~joe-yasi/amarok/+git/amarok-git

Branch merges

Branch information

Name:: kwallethelper

Repository:: lp:~joe-yasi/amarok/+git/amarok-git

Recent commits

01a4ce7... by Frank Meerkötter on 2013-08-25

EBN: Check for foreach loop issues.

Fixing a number of issues from
http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html
[...]
13. Check for foreach loop issues [foreach]...
[...]

Prefer a const reference over a copy. This patch is only a first
batch - fixing the simple cases.

BUG: 313504
REVIEW: 112199

61350cc... by Frank Meerkötter on 2013-08-25

EBN: Prefer QChar overloads over the QString ones.

CCBUG: 313504
REVIEW: 112221

c62665c... by Frank Meerkötter on 2013-08-25

UMS: Fix setting album cover.

When Setting->Config->Metadata->Write covers to file is enabled, it
should be possible to write covers for albums located on an UMS
collection. The current status is that amarok does the write but
never updates itself to reflect the new cover. There is code to
achive this but is has been broken at some point.

File_p.h:358 tries to create a signal/slot connection to an invalid
slot. This is fixed by my patch.

REVIEW: 112255

2b87fb4... by Mark Kretschmann on 2013-08-22