Merge ~jocave/plainbox-provider-snappy:turn-on-sysrq into plainbox-provider-snappy:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: 35d4b5fb91ea404a484c912d0ecff4ce2ccc820e
Merged at revision: b7b8b0de8b7878ee78d33847f8180975f2193d70
Proposed branch: ~jocave/plainbox-provider-snappy:turn-on-sysrq
Merge into: plainbox-provider-snappy:master
Diff against target: 12 lines (+1/-0)
1 file modified
units/watchdog/jobs.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Sylvain Pineau (community) Approve
Review via email: mp+360797@code.launchpad.net

Description of the change

Make sure all functions of kernel sysrq are enabled before attempting to trigger an event.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [09:33:07] starting container
Device project added to xenial-testing
[bionic] [09:33:12] starting container
[trusty] [09:33:14] starting container
Device project added to bionic-testing
Device project added to trusty-testing
[xenial] [09:33:19] provisioning container
[bionic] [09:33:30] provisioning container
[trusty] [09:33:30] provisioning container
[bionic] [09:34:33] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/JJ2KN8pM3g/
[bionic] [09:34:36] Fixing file permissions in source directory
[bionic] Destroying failed container to reclaim resources
[xenial] [09:34:44] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-snappy
[trusty] [09:34:50] Starting tests...
[trusty] Found a test script: ./requirements/container-tests-provider-snappy
[trusty] [09:35:13] container-tests-provider-snappy: PASS
[trusty] [09:35:13] Fixing file permissions in source directory
[xenial] [09:35:13] container-tests-provider-snappy: PASS
[xenial] [09:35:13] Fixing file permissions in source directory
[trusty] [09:35:14] Destroying container
[xenial] [09:35:14] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/watchdog/jobs.pxu b/units/watchdog/jobs.pxu
2index 9767e8e..76f5278 100644
3--- a/units/watchdog/jobs.pxu
4+++ b/units/watchdog/jobs.pxu
5@@ -42,6 +42,7 @@ _steps:
6 _verification:
7 Did the board reset itself?
8 command:
9+ echo 1 > /proc/sys/kernel/sysrq
10 echo 0 > /proc/sys/kernel/panic
11 echo c > /proc/sysrq-trigger
12 flags: noreturn preserve-locale

Subscribers

People subscribed via source and target branches