Merge ~jocave/plainbox-provider-snappy:add-plans-for-nesting into plainbox-provider-snappy:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Sylvain Pineau
Approved revision: ffc09cdecde9491cb5c5f048ab50b9e42a747d5c
Merged at revision: 060e9433b435ed40ddf6e2cc273abf50a576b101
Proposed branch: ~jocave/plainbox-provider-snappy:add-plans-for-nesting
Merge into: plainbox-provider-snappy:master
Diff against target: 88 lines (+37/-2)
4 files modified
units/cpu/test-plan.pxu (+6/-0)
units/memory/test-plan.pxu (+6/-0)
units/rtc/test-plan.pxu (+6/-0)
units/wireless/test-plan.pxu (+19/-2)
Reviewer Review Type Date Requested Status
Devices Certification Bot Needs Fixing
Sylvain Pineau (community) Approve
Review via email: mp+359826@code.launchpad.net

Description of the change

Add missing manual/automated/full plans for nesting where missing to make creation of top-level plans easier.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Looks good, +1

review: Approve
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [16:41:03] Unable to update pristine container!
[bionic] [16:41:04] starting container
Device project added to bionic-testing
[xenial] output: https://paste.ubuntu.com/p/WwVMHQHBd6/
[xenial] NOTE: unable to execute tests, marked as failed
[xenial] Trying to destroy to reclaim possible resources
[xenial] [16:41:06] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-snappy
[xenial] [16:41:07] container-tests-provider-snappy: FAIL
[trusty] [16:41:08] starting container
[xenial] output: https://paste.ubuntu.com/p/cgq4fywHRS/
[xenial] [16:41:09] Fixing file permissions in source directory
[xenial] [16:41:09] Unable to fix permissions!
Device project added to trusty-testing
[xenial] output: https://paste.ubuntu.com/p/vGh4cG4w9D/
[xenial] Some files owned by root may have been left around, fix them manually with chown.
[xenial] [16:41:12] Destroying container
[xenial] [16:41:12] Unable to stop container!
[xenial] output: https://paste.ubuntu.com/p/jdMYgY5XFn/
[xenial] You may need to manually 'lxc stop -f xenial-testing' to fix this
[bionic] [16:41:20] provisioning container
[bionic] [16:41:20] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/nxBXXd7sj9/
[bionic] [16:41:22] Fixing file permissions in source directory
[bionic] [16:41:22] Unable to fix permissions!
[trusty] [16:41:23] provisioning container
[trusty] [16:41:23] Unable to provision requirements in container!
[bionic] output: https://paste.ubuntu.com/p/QRrkmx47PN/
[bionic] Some files owned by root may have been left around, fix them manually with chown.
[bionic] Destroying failed container to reclaim resources
[trusty] output: https://paste.ubuntu.com/p/jx5Qk7CgX2/
[trusty] [16:41:25] Fixing file permissions in source directory
[trusty] [16:41:25] Unable to fix permissions!
[trusty] output: https://paste.ubuntu.com/p/Bh4jqYN4Mq/
[trusty] Some files owned by root may have been left around, fix them manually with chown.
[trusty] Destroying failed container to reclaim resources

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [17:39:45] starting container
[xenial] [17:39:47] starting container
Device project added to bionic-testing
Device project added to xenial-testing
[bionic] [17:39:59] provisioning container
[bionic] [17:39:59] Unable to provision requirements in container!
[xenial] [17:40:00] provisioning container
[xenial] [17:40:00] Unable to provision requirements in container!
[xenial] output: https://paste.ubuntu.com/p/gZFmR3Ntpm/
[xenial] [17:40:02] Fixing file permissions in source directory
[bionic] output: https://paste.ubuntu.com/p/fXwNZhQr9C/
[bionic] [17:40:02] Fixing file permissions in source directory
[xenial] [17:40:02] Unable to fix permissions!
[trusty] [17:40:03] starting container
[bionic] [17:40:03] Unable to fix permissions!
Device project added to trusty-testing
[xenial] output: https://paste.ubuntu.com/p/ZXFZw5SzvN/
[xenial] Some files owned by root may have been left around, fix them manually with chown.
[xenial] Destroying failed container to reclaim resources
[bionic] output: https://paste.ubuntu.com/p/RCDBtqTp8c/
[bionic] Some files owned by root may have been left around, fix them manually with chown.
[bionic] Destroying failed container to reclaim resources
[trusty] [17:40:15] provisioning container
[trusty] [17:40:15] Unable to provision requirements in container!
[trusty] output: https://paste.ubuntu.com/p/bcffFtcBQY/
[trusty] [17:40:17] Fixing file permissions in source directory
[trusty] [17:40:17] Unable to fix permissions!
[trusty] output: https://paste.ubuntu.com/p/Ms2x4RK4TC/
[trusty] Some files owned by root may have been left around, fix them manually with chown.
[trusty] Destroying failed container to reclaim resources

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [20:16:16] starting container
Device project added to xenial-testing
[bionic] [20:16:19] starting container
Device project added to bionic-testing
[xenial] [20:16:28] provisioning container
[trusty] [20:16:30] starting container
Device project added to trusty-testing
[bionic] [20:16:33] provisioning container
[trusty] [20:16:51] provisioning container
[xenial] [20:17:17] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-snappy
[xenial] [20:17:17] container-tests-provider-snappy: FAIL
[xenial] output: https://paste.ubuntu.com/p/s9vRNmS6Yv/
[xenial] [20:17:19] Fixing file permissions in source directory
[bionic] [20:17:20] Starting tests...
[xenial] [20:17:20] Destroying container
[bionic] Found a test script: ./requirements/container-tests-provider-snappy
[bionic] [20:17:20] container-tests-provider-snappy: FAIL
[bionic] output: https://paste.ubuntu.com/p/GTRB9HSVD9/
[bionic] [20:17:22] Fixing file permissions in source directory
[bionic] [20:17:22] Destroying container
[trusty] [20:18:40] Starting tests...
[trusty] Found a test script: ./requirements/container-tests-provider-snappy
[trusty] [20:18:40] container-tests-provider-snappy: FAIL
[trusty] output: https://paste.ubuntu.com/p/Dt2fzWqZ82/
[trusty] [20:18:42] Fixing file permissions in source directory
[trusty] [20:18:42] Destroying container

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[bionic] [22:23:14] starting container
Device project added to bionic-testing
[xenial] [22:23:20] starting container
Device project added to xenial-testing
[bionic] [22:23:26] provisioning container
[trusty] [22:23:30] starting container
Device project added to trusty-testing
[trusty] [22:23:42] provisioning container
[xenial] [22:23:42] provisioning container
[bionic] [22:24:04] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-snappy
[xenial] [22:24:14] Starting tests...
[xenial] Found a test script: ./plainbox-provider-docker/requirements/container-tests-provider-docker
[xenial] [22:24:22] container-tests-provider-docker: PASS
[xenial] Found a test script: ./plainbox-provider-ipdt/requirements/container-tests-provider-ipdt
[xenial] [22:24:22] container-tests-provider-ipdt: FAIL
[bionic] [22:24:22] container-tests-provider-snappy: PASS
[bionic] [22:24:22] Fixing file permissions in source directory
[bionic] [22:24:22] Destroying container
[xenial] output: https://paste.ubuntu.com/p/57zTVGrGHj/
[xenial] Found a test script: ./plainbox-provider-resource/requirements/container-tests-provider-resource-generic
[xenial] [22:24:24] container-tests-provider-resource-generic: FAIL
[xenial] output: https://paste.ubuntu.com/p/Fwmkb378Rg/
[xenial] Found a test script: ./requirements/container-tests-provider-snappy
[trusty] [22:24:38] Starting tests...
[trusty] Found a test script: ./plainbox-provider-docker/requirements/container-tests-provider-docker
[xenial] [22:24:46] container-tests-provider-snappy: FAIL
[trusty] [22:24:46] container-tests-provider-docker: PASS
[trusty] Found a test script: ./plainbox-provider-ipdt/requirements/container-tests-provider-ipdt
[trusty] [22:24:46] container-tests-provider-ipdt: FAIL
[xenial] output: https://paste.ubuntu.com/p/X5k9Gt7n2X/
[xenial] [22:24:48] Fixing file permissions in source directory
[xenial] [22:24:48] Destroying container
[trusty] output: https://paste.ubuntu.com/p/7fqS9QCxGK/
[trusty] Found a test script: ./plainbox-provider-resource/requirements/container-tests-provider-resource-generic
[trusty] [22:24:48] container-tests-provider-resource-generic: FAIL
[trusty] output: https://paste.ubuntu.com/p/cFjZ4gy48b/
[trusty] Found a test script: ./requirements/container-tests-provider-snappy
[trusty] [22:25:10] container-tests-provider-snappy: PASS
[trusty] [22:25:10] Fixing file permissions in source directory
[trusty] [22:25:11] Destroying container

review: Needs Fixing
Revision history for this message
Devices Certification Bot (ce-certification-qa) wrote :

The merge was fine but running tests failed.

[xenial] [09:26:36] starting container
Device project added to xenial-testing
[bionic] [09:26:50] starting container
Device project added to bionic-testing
[xenial] [09:26:58] provisioning container
[bionic] [09:27:09] provisioning container
[trusty] [09:27:20] starting container
Device project added to trusty-testing
[trusty] [09:27:35] provisioning container
[bionic] [09:27:57] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-snappy
[xenial] [09:28:09] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-snappy
[xenial] [09:28:09] container-tests-provider-snappy: FAIL
[bionic] [09:28:12] container-tests-provider-snappy: FAIL
[xenial] output: https://paste.ubuntu.com/p/SrzRyNwP84/
[xenial] [09:28:12] Fixing file permissions in source directory
[xenial] [09:28:13] Destroying container
[bionic] output: https://paste.ubuntu.com/p/KF9qWNd98n/
[bionic] [09:28:14] Fixing file permissions in source directory
[bionic] [09:28:15] Destroying container
[trusty] [09:30:54] Starting tests...
[trusty] Found a test script: ./requirements/container-tests-provider-snappy
[trusty] [09:32:14] container-tests-provider-snappy: PASS
[trusty] [09:32:14] Fixing file permissions in source directory
[trusty] [09:32:15] Destroying container

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/cpu/test-plan.pxu b/units/cpu/test-plan.pxu
2index fdc02fc..7a3095c 100644
3--- a/units/cpu/test-plan.pxu
4+++ b/units/cpu/test-plan.pxu
5@@ -6,6 +6,12 @@ include:
6 nested_part:
7 cpu-automated
8
9+id: cpu-manual
10+unit: test plan
11+_name: Manual CPU tests
12+_description: Manual QA CPU tests for Snappy Ubuntu Core devices
13+include:
14+
15 id: cpu-automated
16 unit: test plan
17 _name: Automated CPU tests
18diff --git a/units/memory/test-plan.pxu b/units/memory/test-plan.pxu
19index 3e8bc45..123d437 100644
20--- a/units/memory/test-plan.pxu
21+++ b/units/memory/test-plan.pxu
22@@ -6,6 +6,12 @@ include:
23 nested_part:
24 memory-automated
25
26+id: memory-manual
27+unit: test plan
28+_name: Manual memory tests
29+_description: Manual memory tests for Ubuntu Core devices
30+include:
31+
32 id: memory-automated
33 unit: test plan
34 _name: Automated memory tests
35diff --git a/units/rtc/test-plan.pxu b/units/rtc/test-plan.pxu
36index 40282aa..3b37bf0 100644
37--- a/units/rtc/test-plan.pxu
38+++ b/units/rtc/test-plan.pxu
39@@ -12,3 +12,9 @@ _name: Manual RTC tests
40 _description: Manual RTC tests for Snappy Ubuntu Core devices
41 include:
42 rtc/battery
43+
44+id: rtc-automated
45+unit: test plan
46+_name: Automated RTC tests
47+_description: Automated RTC tests for Snappy Ubuntu Core devices
48+include:
49diff --git a/units/wireless/test-plan.pxu b/units/wireless/test-plan.pxu
50index a6027dc..f5eb371 100644
51--- a/units/wireless/test-plan.pxu
52+++ b/units/wireless/test-plan.pxu
53@@ -87,16 +87,33 @@ bootstrap_include:
54 device
55 wifi_interface_mode
56
57-id: wireless-wowlan
58+id: wireless-wowlan-full
59 unit: test plan
60 _name: QA tests for WoWLAN
61 _description:
62- Wake on Wireless LAN (WoWLAN) tests
63+ Wake on Wireless LAN (WoWLAN) tests
64+include:
65+nested_part:
66+ wireless-wowlan-manual
67+ wireless-wowlan-automated
68+
69+id: wireless-wowlan-manual
70+unit: test plan
71+_name: Manual QA tests for WoWLAN
72+_description:
73+ Manual Wake on Wireless LAN (WoWLAN) tests
74 include:
75 wireless/wowlan_.*
76 bootstrap_include:
77 device
78
79+id: wireless-wowlan-automated
80+unit: test plan
81+_name: Automated QA tests for WoWLAN
82+_description:
83+ Automated Wake on Wireless LAN (WoWLAN) tests
84+include:
85+
86 id: after-suspend-wireless-full
87 unit: test plan
88 _name: Wireless tests (after suspend)

Subscribers

People subscribed via source and target branches