Merge ~jocave/plainbox-provider-snappy:add-summaries into plainbox-provider-snappy:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: d3a4c348aa8f94fd2c173631a5570b69a38ec07a
Merged at revision: 2dddc9d668744d0a7cfc05cda9432dc29d06ac03
Proposed branch: ~jocave/plainbox-provider-snappy:add-summaries
Merge into: plainbox-provider-snappy:master
Diff against target: 52 lines (+6/-2)
3 files modified
units/info.pxu (+1/-1)
units/monitor/jobs.pxu (+2/-1)
units/security/jobs.pxu (+3/-0)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+349362@code.launchpad.net

Description of the change

Identified some key jobs called in test plans that where missing summaries. Generally switched already short `_description` fields to `_summary` and if longer then add a new `_summary`.

Tested the improvement by running list-bootstrapped on various test plans.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

+1.
I see I'm guilty of omitting summaries in the past too.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/info.pxu b/units/info.pxu
2index 8a87053..1961d97 100644
3--- a/units/info.pxu
4+++ b/units/info.pxu
5@@ -4,4 +4,4 @@ category_id: com.canonical.plainbox::info
6 command: cat $SNAP/parts_meta_info
7 environ: SNAP
8 estimated_duration: 0.02
9-_description: Attaches an information about all parts that constituted this snap
10+_summary: Attaches an information about all parts that constituted this snap
11diff --git a/units/monitor/jobs.pxu b/units/monitor/jobs.pxu
12index d1b6900..8e42a69 100644
13--- a/units/monitor/jobs.pxu
14+++ b/units/monitor/jobs.pxu
15@@ -27,7 +27,7 @@ estimated_duration: 300
16 flags: also-after-suspend
17
18 id: monitor/displayport
19-_summary: Monitor works (Displayport)
20+_summary: Monitor works (DisplayPort)
21 _purpose:
22 Check output to display through DisplayPort
23 _steps:
24@@ -69,6 +69,7 @@ estimated_duration: 300
25 flags: also-after-suspend
26
27 id: monitor/displayport_hotplug
28+_summary: Can hotplug monitor (DisplayPort)
29 plugin: manual
30 category_id: com.canonical.plainbox::monitor
31 _purpose:
32diff --git a/units/security/jobs.pxu b/units/security/jobs.pxu
33index 4d042a9..795ac9c 100644
34--- a/units/security/jobs.pxu
35+++ b/units/security/jobs.pxu
36@@ -5,6 +5,8 @@
37 # Maciej Kisielewski <maciej.kisielewski@canonical.com>
38
39 id: security_setup
40+_summary: Setup required for running kernel security tests
41+category_id: security
42 plugin: shell
43 command:
44 cp -r $PLAINBOX_PROVIDER_DATA/kernel-security $PLAINBOX_SESSION_SHARE/
45@@ -18,6 +20,7 @@ unit: template
46 template-resource: security_resource
47 template-unit: job
48 id: security/{name}
49+_summary: Kernel security: {name}
50 command: export PATH=$PLAINBOX_PROVIDER_DATA/kernel-security/_mocks:$PATH && cd $PLAINBOX_SESSION_SHARE && python3 -m unittest {pyobj}
51 plugin: shell
52 requires: cpuinfo.platform == 'i386' or cpuinfo.platform == 'x86_64'

Subscribers

People subscribed via source and target branches