Merge ~jocave/plainbox-provider-resource:bootloader-error-handling into plainbox-provider-resource:master
Proposed by
Jonathan Cave
Status: | Merged |
---|---|
Approved by: | Jonathan Cave |
Approved revision: | 8b8e139fb1ca11604852d85a62faf23fc322b7af |
Merged at revision: | cb370b9745da62272bb03cd90d775eb8b3f4933c |
Proposed branch: | ~jocave/plainbox-provider-resource:bootloader-error-handling |
Merge into: | plainbox-provider-resource:master |
Diff against target: |
29 lines (+17/-1) 1 file modified
bin/bootloader_resource.py (+17/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sylvain Pineau (community) | Approve | ||
Review via email: mp+378327@code.launchpad.net |
Description of the change
Improve bootloader_
To post a comment you must log in.
(11:27:53 AM) spineau: joc: how can I test it, just classic?
(11:31:55 AM) spineau: joc: '(hd1,gpt1)' looks a bit restrictive. could we wee a system with for example hd0, gpt2 ?
(11:32:03 AM) spineau: wee/see
(11:32:18 AM) joc: i have no idea
(11:32:27 AM) joc: this is a question for the delivery team i think
(11:35:47 AM) spineau: joc: I'm ok to land and revisit the rule when a new project will come and fail with an 'unknown' grub_path. If it solves fortknox that's already an improvement