Merge ~jocave/plainbox-provider-resource:init-category-variable into plainbox-provider-resource:master

[Jonathan Cave]

Makes sure the category_scope_manager variable is always initialised before being referenced e.g. when there is no netplan config at all.

[Sylvain Pineau (sylvain-pineau)]

+1, thx

review: Approve

[Devices Certification Bot (ce-certification-qa)]

The merge was fine but running tests failed.

[bionic] [10:26:11] starting container
[xenial] [10:26:12] starting container
Device project added to bionic-testing
Device project added to xenial-testing
[xenial] [10:26:22] provisioning container
[bionic] [10:26:24] provisioning container
[xenial] [10:26:47] Starting tests...
[xenial] Found a test script: ./requirements/container-tests-provider-resource-generic
[bionic] [10:26:47] Starting tests...
[bionic] Found a test script: ./requirements/container-tests-provider-resource-generic
[bionic] [10:28:03] container-tests-provider-resource-generic: FAIL
[xenial] [10:28:03] container-tests-provider-resource-generic: FAIL
[xenial] output: https://paste.ubuntu.com/p/4xNnTMC2t6/
[bionic] output: https://paste.ubuntu.com/p/HTKfyR49XZ/
[xenial] [10:28:06] Fixing file permissions in source directory
[bionic] [10:28:06] Fixing file permissions in source directory
[xenial] [10:28:06] Destroying container
[bionic] [10:28:06] Destroying container

review: Needs Fixing

diff --git a/bin/net_if_management.py b/bin/net_if_management.py
index 1b08274..c4604c3 100755
--- a/bin/net_if_management.py
+++ b/bin/net_if_management.py
@@ -89,10 +89,13 @@ def main():
         print('device: {}'.format(n))
         print('nmcli_available: {}'.format(nm_conf.available))
 
+        category_scope_manager = States.unspecified.value
         if n in netplan_conf.wifis:
-            category_scope_manager = netplan_conf.wifis.get('renderer')
+            category_scope_manager = netplan_conf.wifis.get(
+                'renderer', States.unspecified.value)
         elif n in netplan_conf.ethernets:
-            category_scope_manager = netplan_conf.ethernets.get('renderer')
+            category_scope_manager = netplan_conf.ethernets.get(
+                'renderer', States.unspecified.value)
 
         # Netplan config indcates NM
         if (global_scope_manager == States.nm.value or