Merge lp:~jocave/plainbox-provider-phablet/radio_tests into lp:plainbox-provider-phablet

Proposed by Jonathan Cave
Status: Merged
Approved by: Daniel Manrique
Approved revision: 7
Merged at revision: 5
Proposed branch: lp:~jocave/plainbox-provider-phablet/radio_tests
Merge into: lp:plainbox-provider-phablet
Diff against target: 153 lines (+144/-0)
2 files modified
2013.com.canonical.certification:phablet/bin/test_flight_mode (+11/-0)
2013.com.canonical.certification:phablet/units/radio.txt (+133/-0)
To merge this branch: bzr merge lp:~jocave/plainbox-provider-phablet/radio_tests
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+224570@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Awesome!

We'll probably need to change the device.* stuff to depend on the new "manifest" resource, but that's not yet ready...

for multi-line requirements, leave requires: alone on a line and put the requirements in subsequent lines, with at least one space at the beginning, so:

requires:
  device.category == 'FOO'
  package.name == 'bar'

Please add underscores to "description" (so _description) so they can be localized later if needed.

Add a "_summary" field to jobs; the summary is a short (20-30 characters) description meant to be displayed by UIs, so it's not as long and detailed as the description but not as succint or limited as the job id. Watch out for the underscore in the field name.

Thanks!

review: Needs Fixing
7. By Jonathan Cave

 * correct requires layout
 * mark descriptions translatable
 * add summary fields

Revision history for this message
Jonathan Cave (jocave) wrote :

Hopefully fixes in push above!

Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks! Approving and let's see what tarmac thinks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '2013.com.canonical.certification:phablet/bin/test_flight_mode'
2--- 2013.com.canonical.certification:phablet/bin/test_flight_mode 1970-01-01 00:00:00 +0000
3+++ 2013.com.canonical.certification:phablet/bin/test_flight_mode 2014-06-26 10:02:47 +0000
4@@ -0,0 +1,11 @@
5+#!/bin/sh -x
6+
7+# turn on flight mode
8+/usr/share/urfkill/scripts/flight-mode 1
9+
10+# give radios time to go down
11+sleep 10
12+
13+# turn off flight mode
14+/usr/share/urfkill/scripts/flight-mode 0
15+
16
17=== added file '2013.com.canonical.certification:phablet/units/radio.txt'
18--- 2013.com.canonical.certification:phablet/units/radio.txt 1970-01-01 00:00:00 +0000
19+++ 2013.com.canonical.certification:phablet/units/radio.txt 2014-06-26 10:02:47 +0000
20@@ -0,0 +1,133 @@
21+id: radio-001
22+plugin: attachment
23+command: adb_test check-modem
24+requires: device.category == 'MODEM'
25+_summary: Verify that the cellular modem is on
26+_description:
27+ Verifies that ofono is running and that the modem is powered.
28+ Additional info is displayed to verify connection to the network, which should
29+ be online if a proper sim is inserted.
30+estimated_duration: 1
31+
32+id: radio-002
33+plugin: attachment
34+command: adb_test check-radio-devices
35+requires: device.category == 'MODEM'
36+_summary: Verfiy at that a radio device is available
37+_description:
38+ Verifies that at least an ofono radio device is available.
39+ Additional radio devices are listed for manual verification depending on the
40+ connected hardware.
41+estimated_duration: 1
42+
43+id: radio-003
44+plugin: user-verify
45+requires:
46+ package.name == 'urfkill'
47+ device.category == 'MODEM' or device.category == 'WIRELESS' or device.category == 'BLUETOOTH'
48+command: adb_test test_flight_mode
49+_summary: Verify Flight Mode works
50+_description:
51+ Verifies that turning off the radios and then on again works
52+estimated_duration: 30.0
53+
54+id: wireless-001
55+plugin: user-interact-verify
56+requires:
57+ package.name == 'phablet-tools'
58+ device.category == 'WIRELESS'
59+command: phablet-network
60+_summary: Verify can connect to Wireless B/G networks
61+_description:
62+ STEPS:
63+ 1. Connect the host machine to a Wireless B/G network
64+ VERIFICATION:
65+ Confirm that the target device is connected to the wireless network
66+estimated_duration: 15.0
67+
68+id: wireless-002
69+plugin: user-interact-verify
70+requires:
71+ package.name == 'phablet-tools'
72+ device.category == 'WIRELESS'
73+command: phablet-network
74+_summary: Verify can connect to Wireless N networks
75+_description:
76+ STEPS:
77+ 1. Connect the host machine to a Wireless N network
78+ VERIFICATION:
79+ Confirm that the target device is connected to the wireless network
80+estimated_duration: 15.0
81+
82+id: wireless-003
83+plugin: user-interact-verify
84+requires:
85+ package.name == 'phablet-tools'
86+ device.category == 'WIRELESS'
87+command: phablet-network
88+_description:
89+ STEPS:
90+ 1. Connect the host machine to a Wireless A network
91+ VERIFICATION:
92+ Confirm that the target device is connected to the wireless network
93+estimated_duration: 15.0
94+
95+id: bluetooth-001
96+plugin: manual
97+requires:
98+ package.name == 'bluez'
99+ device.category == 'BLUETOOTH'
100+_summary: Verify Bluetooth is active
101+_description:
102+ STEPS:
103+ 1. Turn on a Bluetooth device (e.g. wireless speaker) and place in discoverable mode
104+ 2. On the target, run hcitool scan to scan for devices
105+ VERIFICATION:
106+ Is the bluetooth device listed in the scan results
107+estimated_duration: 40.0
108+
109+id: bluetooth-002
110+plugin: manual
111+requires:
112+ package.name == 'bluez'
113+ package.name == 'alsa-utils'
114+ device.category == 'BLUETOOTH'
115+_summary: Verify can route audio to a Bluetooth device
116+_description:
117+ STEPS:
118+ 1. Enable the bluetooth headset or speaker in discovery mode
119+ 2. run hcitool scan to get mac address of device
120+ 3. bluez-simple-agent hci0 <mac address from step 2>
121+ 4. bluez-test-audio connect <mac address from step 2>
122+ 5. aplay /usr/share/sounds/alsa/Front_Center.wav
123+ 6. bluez-test-audio disconnect <mac address from step 2>
124+ VERIFICATION:
125+ 1. verify speaker or headset is enabled
126+ 2. verify scan tool returns mac address
127+ 3. verify bluez-simple-agent authorizes
128+ 4. verify bluez-test-audio returns true
129+ 5. verify sound plays on BT speaker/headset
130+ 7. verify bluez-test-audio disconnect returns true
131+estimated_duration: 120.0
132+
133+id: bluetooth-003
134+plugin: manual
135+requires:
136+ package.name == 'bluez'
137+ device.category == 'BLUETOOTH'
138+_summary: Verify can use a Bluetooth input device
139+_description:
140+ STEPS:
141+ 1. Enable the bluetooth input device in discovery mode
142+ 2. run hcitool scan to get mac address of device
143+ 3. bluez-simple-agent hci0 <mac address from step 2>
144+ 4. bluez-test-input connect <mac address from step 2>
145+ 5. bluez-test-input disconnect <mac address from step 2>
146+ VERIFICATION:
147+ 1. verify input device is enabled
148+ 2. verify scan tool returns mac address
149+ 3. verify simple agent authorizes
150+ 4. verify test-input connect returns true
151+ 5. verify test-input disconnect returns true
152+estimated_duration: 120.0
153+

Subscribers

People subscribed via source and target branches