Merge lp:~jocave/plainbox-provider-phablet/radio_tests into lp:plainbox-provider-phablet
Proposed by
Jonathan Cave
Status: | Merged |
---|---|
Approved by: | Daniel Manrique |
Approved revision: | 7 |
Merged at revision: | 5 |
Proposed branch: | lp:~jocave/plainbox-provider-phablet/radio_tests |
Merge into: | lp:plainbox-provider-phablet |
Diff against target: |
153 lines (+144/-0) 2 files modified
2013.com.canonical.certification:phablet/bin/test_flight_mode (+11/-0) 2013.com.canonical.certification:phablet/units/radio.txt (+133/-0) |
To merge this branch: | bzr merge lp:~jocave/plainbox-provider-phablet/radio_tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Daniel Manrique (community) | Approve | ||
Review via email: mp+224570@code.launchpad.net |
To post a comment you must log in.
Awesome!
We'll probably need to change the device.* stuff to depend on the new "manifest" resource, but that's not yet ready...
for multi-line requirements, leave requires: alone on a line and put the requirements in subsequent lines, with at least one space at the beginning, so:
requires:
device.category == 'FOO'
package.name == 'bar'
Please add underscores to "description" (so _description) so they can be localized later if needed.
Add a "_summary" field to jobs; the summary is a short (20-30 characters) description meant to be displayed by UIs, so it's not as long and detailed as the description but not as succint or limited as the job id. Watch out for the underscore in the field name.
Thanks!