Checkbox Provider - Base

Merge ~jocave/plainbox-provider-checkbox:user-root-interface-bind into plainbox-provider-checkbox:master

  1. Git
  2. lp:~jocave/plainbox-provider-checkbox
  3. user-root-interface-bind
  4. Merge into master
Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: e126d6b6b66883139707fdad1542072fc8d04a24
Merged at revision: 1f8ea759f45d7d895b97d6ad6dd8d3f4e2fef2d1
Proposed branch: ~jocave/plainbox-provider-checkbox:user-root-interface-bind
Merge into: plainbox-provider-checkbox:master
Diff against target: 12 lines (+1/-0)
1 file modified
units/ethernet/jobs.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Jonathan Cave (community) Approve
Review via email: mp+382873@code.launchpad.net

Description of the change

There have been a number of failures on recent upgrade-testing runs of the job ethernet/ping_{interface}. This appears to be because the testing now correctly switches to a "normal_user" without elevated permissions and is prevented from binding a socket to the interface under test. Hence, always run as root.

Tested on xps13-7390-2in1 with a typical SRU launcher.

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

self-approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/ethernet/jobs.pxu b/units/ethernet/jobs.pxu
2index bd7f273..6a48955 100644
3--- a/units/ethernet/jobs.pxu
4+++ b/units/ethernet/jobs.pxu
5@@ -176,6 +176,7 @@ command:
6 category_id: com.canonical.plainbox::ethernet
7 estimated_duration: 4.0
8 flags: preserve-locale also-after-suspend
9+user: root
10
11 unit: template
12 template-resource: device

Subscribers

People subscribed via source and target branches