Checkbox Provider - Base

Merge ~jocave/plainbox-provider-checkbox:lp1812160 into plainbox-provider-checkbox:master

  1. Git
  2. lp:~jocave/plainbox-provider-checkbox
  3. lp1812160
  4. Merge into master
Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: 2b089b0d0d28813f1833b65eefd793d63e05aae3
Merged at revision: fb9c8270ce3b8d24392db6b2c175311a86c52bb2
Proposed branch: ~jocave/plainbox-provider-checkbox:lp1812160
Merge into: plainbox-provider-checkbox:master
Diff against target: 54 lines (+10/-8)
1 file modified
units/monitor/test-plan.pxu (+10/-8)
Reviewer Review Type Date Requested Status
Paul Larson Needs Information
Review via email: mp+367520@code.launchpad.net

Description of the change

Applying the re-ordering of the test plans requested in lp bug #1812160.

Same changes applied to the after-suspend test plan.

To post a comment you must log in.
Revision history for this message
Jonathan Cave (jocave) wrote :

I notice lp bug #1825151 says a different arrangement of these tests caused a crash in one of test scripts. So it's possible this is not safe.

Revision history for this message
Paul Larson (pwlars) wrote :

Sounds like that other bug needs to be fixed first then? Only other comment I would have is that it might be nice to add a comment to make it clear they are in "video tests" and "audio tests" sections, in case other tests are added in the future, this might help keep them organized

review: Needs Information
Revision history for this message
Ray Chen (ray.chen) wrote :

Was tested the order this morning, lp bug #1825151 and lp bug #1829827 are no longer exists.

I would +1 after remove comment symbol.

Revision history for this message
Jonathan Cave (jocave) wrote :

09:07 <joc> RayChen: i think the existing MR should land as is and there can be a second one for creation of the job(s)
09:07 <RayChen> joc: agree

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/monitor/test-plan.pxu b/units/monitor/test-plan.pxu
2index fbed317..e138abf 100644
3--- a/units/monitor/test-plan.pxu
4+++ b/units/monitor/test-plan.pxu
5@@ -27,19 +27,20 @@ include:
6 monitor/1_powersaving_.* certification-status=blocker
7 monitor/1_dim_brightness_.* certification-status=blocker
8 monitor/1_displayport_.* certification-status=blocker
9+ audio/1_playback_displayport_.* certification-status=blocker
10 monitor/1_type-c_displayport_.* certification-status=blocker
11+ audio/1_playback_type-c_displayport_.* certification-status=blocker
12 monitor/type-c-to-hdmi certification-status=blocker
13+ # placeholder for monitor/1_type-c_hdmi_.*
14 monitor/type-c-to-vga certification-status=blocker
15- audio/1_playback_displayport_.* certification-status=blocker
16- audio/1_playback_type-c_displayport_.* certification-status=blocker
17 monitor/1_dvi_.* certification-status=blocker
18 monitor/1_hdmi_.* certification-status=blocker
19 audio/1_playback_hdmi_.* certification-status=blocker
20 monitor/1_thunderbolt_.* certification-status=blocker
21- monitor/1_thunderbolt3_.* certification-status=non-blocker
22 audio/1_playback_thunderbolt_.* certification-status=blocker
23- audio/1_playback_thunderbolt3_.* certification-status=non-blocker
24 thunderbolt/daisy-chain certification-status=blocker
25+ monitor/1_thunderbolt3_.* certification-status=non-blocker
26+ audio/1_playback_thunderbolt3_.* certification-status=non-blocker
27 thunderbolt3/daisy-chain certification-status=non-blocker
28 monitor/1_vga_.* certification-status=blocker
29 monitor/1_multi-head_.* certification-status=blocker
30@@ -55,19 +56,20 @@ include:
31 (after-suspend-manual-)?monitor/1_powersaving_.* certification-status=blocker
32 (after-suspend-manual-)?monitor/1_dim_brightness_.* certification-status=blocker
33 (after-suspend-manual-)?monitor/1_displayport_.* certification-status=blocker
34+ (after-suspend-manual-)?audio/1_playback_displayport_.* certification-status=blocker
35 (after-suspend-manual-)?monitor/1_type-c_displayport_.* certification-status=blocker
36+ (after-suspend-manual-)?audio/1_playback_type-c_displayport_.* certification-status=blocker
37 (after-suspend-manual-)?monitor/type-c-to-hdmi certification-status=blocker
38+ # placeholder for (after-suspend-manual-)?monitor/1_type-c_hdmi_.*
39 (after-suspend-manual-)?monitor/type-c-to-vga certification-status=blocker
40- (after-suspend-manual-)?audio/1_playback_displayport_.* certification-status=blocker
41- (after-suspend-manual-)?audio/1_playback_type-c_displayport_.* certification-status=blocker
42 (after-suspend-manual-)?monitor/1_dvi_.* certification-status=blocker
43 (after-suspend-manual-)?monitor/1_hdmi_.* certification-status=blocker
44 (after-suspend-manual-)?audio/1_playback_hdmi_.* certification-status=blocker
45 (after-suspend-manual-)?monitor/1_thunderbolt_.* certification-status=blocker
46- (after-suspend-manual-)?monitor/1_thunderbolt3_.* certification-status=non-blocker
47 (after-suspend-manual-)?audio/1_playback_thunderbolt_.* certification-status=blocker
48- (after-suspend-manual-)?audio/1_playback_thunderbolt3_.* certification-status=non-blocker
49 (after-suspend-manual-)?thunderbolt/daisy-chain certification-status=blocker
50+ (after-suspend-manual-)?monitor/1_thunderbolt3_.* certification-status=non-blocker
51+ (after-suspend-manual-)?audio/1_playback_thunderbolt3_.* certification-status=non-blocker
52 (after-suspend-manual-)?thunderbolt3/daisy-chain certification-status=non-blocker
53 (after-suspend-manual-)?monitor/1_vga_.* certification-status=blocker
54 (after-suspend-manual-)?monitor/1_multi-head_.* certification-status=blocker

Subscribers

People subscribed via source and target branches