Checkbox Provider - Base

Merge ~jocave/plainbox-provider-checkbox:socketcan-manifest-question into plainbox-provider-checkbox:master

  1. Git
  2. lp:~jocave/plainbox-provider-checkbox
  3. socketcan-manifest-question
  4. Merge into master
Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: 2aaed26da965b9e1c006f53075b4667de548d0dd
Merged at revision: eb249ff0278989f104b25504a1c13aaccb36100a
Proposed branch: ~jocave/plainbox-provider-checkbox:socketcan-manifest-question
Merge into: plainbox-provider-checkbox:master
Diff against target: 12 lines (+2/-1)
1 file modified
units/socketcan/manifest.pxu (+2/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+353871@code.launchpad.net

Description of the change

Add a custom prompt to the socketcan manifest that makes a little more sense. Tested that it works with latest checkbox-ng in a snap.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/socketcan/manifest.pxu b/units/socketcan/manifest.pxu
2index bb140c4..2c9b898 100644
3--- a/units/socketcan/manifest.pxu
4+++ b/units/socketcan/manifest.pxu
5@@ -1,5 +1,6 @@
6
7 unit: manifest entry
8 id: socket_can_echo_server_running
9-_name: SocketCAN Echo Server Running
10+prompt: Is the device connected to the following?:
11+_name: A SocketCAN Echo Server
12 value-type: bool

Subscribers

People subscribed via source and target branches