Merge ~jocave/plainbox-provider-checkbox:non-syslog-armvfp into plainbox-provider-checkbox:master

[Jonathan Cave]

The arm_vfp_support did not work on arm64 devices and was also subject to problems if syslog managed such that capability info was no longer available.

Although there are other ways to test this, checking for some flags seems the simplest at the moment.

[Paul Larson (pwlars)]

cool, +1

review: Approve

[Sylvain Pineau (sylvain-pineau)]

+1 nice use of template fields

review: Approve

diff --git a/units/cpu/jobs.pxu b/units/cpu/jobs.pxu
index db0dd8f..adf34b9 100644
--- a/units/cpu/jobs.pxu
+++ b/units/cpu/jobs.pxu
@@ -100,18 +100,37 @@ command: nice -n -20 frequency_governors_test --debug
 _description:
  This test checks that CPU frequency governors are obeyed when set.
 
+unit: template
+template-resource: cpuinfo
+template-filter: cpuinfo.platform == 'armv7l'
+template-unit: job
 plugin: shell
 category_id: com.canonical.plainbox::cpu
-id: cpu/arm_vfp_support
+id: cpu/arm_vfp_support_{platform}
 estimated_duration: 1.0
-requires:
- cpuinfo.platform in ("armv7l", "aarch64")
 user: root
-command: grep VFP /var/log/syslog
+command:
+  echo "{other}" | grep "vfp\|vfpv3\|vfpv4\|vfpd32"
+_summary:
+ Validate that the Vector Floating Point Unit is running on {platform} device
+_description:
+ Validate that the Vector Floating Point Unit is running on {platform} device.
+
+unit: template
+template-resource: cpuinfo
+template-filter: cpuinfo.platform == 'aarch64'
+template-unit: job
+plugin: shell
+category_id: com.canonical.plainbox::cpu
+id: cpu/arm_vfp_support_{platform}
+estimated_duration: 1.0
+user: root
+command:
+  echo "{other}" | grep "fp"
 _summary:
- Validate that the Vector Floating Point Unit is running on ARM device
+ Validate that the Floating Point Unit is running on {platform} device
 _description:
- Validate that the Vector Floating Point Unit is running on ARM device.
+ Validate that the Floating Point Unit is running on {platform} device.
 
 plugin:shell
 id: cpu/cstates