Checkbox Provider - Base

Merge ~jocave/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:make-hdapsd-optional into ~checkbox-dev/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:master

  1. Git
  2. lp:~jocave/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts
  3. make-hdapsd-optional
  4. Merge into master
Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: 47f75e090f9e9cc30ab9a1b49d980850e0dd8938
Merged at revision: 4f4133d54221d0824f6c63327fde43a8184d6032
Proposed branch: ~jocave/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:make-hdapsd-optional
Merge into: ~checkbox-dev/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:master
Diff against target: 13 lines (+1/-1)
1 file modified
snapcraft.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Maciej Kisielewski Approve
Review via email: mp+347987@code.launchpad.net

Description of the change

hdapsd package is not available on arm devices but it is unlikely we will actually run these tests on that platform so make the package optional.

Tested that this enables building on arm64

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

TIL about `try`.
+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 7dda386..1c8e517 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -22,7 +22,7 @@ parts:
6 - gir1.2-gst-plugins-base-1.0
7 - gir1.2-gudev-1.0
8 - gstreamer1.0-pulseaudio
9- - hdapsd
10+ - try: [hdapsd] # optional as not available for arm
11 - hdparm
12 - ipmitool
13 - iperf

Subscribers

People subscribed via source and target branches