Merge ~jocave/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:stage-package-updates-from-oem-qa into ~checkbox-dev/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:master

[Jonathan Cave]

checkbox-oem-qa has been tested thoroughly and has identified more test dependencies.

This merge re-orders existing stage-packages in the first commit and then adds any found in checkbox-oem-qa in the second.

This makes the wiki part for plainbox-provider-checkbox closer to being "off-the-shelf" usable at the expense of an increase in size of snaps already using it. In my opinion this is the approach that should be taken and if there is a desire to make snaps smaller then the providers should be split up to be more category specific.

[Paul Larson (pwlars)]

Yeah, I think it's generally understood that you are sacrificing size for consistency in snaps. Did you mean to leave wget and python3-yaml in the list but commented out?
Otherwise, +1

review: Approve

[Sylvain Pineau (sylvain-pineau)]

Thanks for initiating this, couple of modifications based on my work on classic:

Please remove:

- fwts (rather use the dedicated part to get an up-to-date version, even the "local" one you wrote)
- zenity

Add:

- iperf
- iperf3

Uncomment:

#- python3-yaml (I needed this one for checkbox-tillamook)

review: Needs Fixing

[Jonathan Cave (jocave)]

Made changes requested by Sylvain

[Sylvain Pineau (sylvain-pineau)]

checkbox-oem-qa is ~ 150MB which is not that big as several years ago (yeah, time goes fast) Jeff complained that we were pulling 500MB of desktop dependencies via the p-p-c provider.

+1

review: Approve

[Sylvain Pineau (sylvain-pineau)]

Note: both checkbox-snappy and checkbox-plano will need the fwts-local part patch

[Sylvain Pineau (sylvain-pineau)]

We're holding this MR until checkbox-plano* V37 are promoted to --stable

diff --git a/snapcraft.yaml b/snapcraft.yaml
index ea5d3df..6253ca4 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -11,26 +11,43 @@ parts:
     source-type: git
     source: git://git.launchpad.net/plainbox-provider-checkbox
     stage-packages:
-      #- python3-yaml
-      - usbutils
-      - fwts
-      - lshw
-      #- bluez-tests
-      - python3-dbus
-      #- bonnie++
-      - hdparm
-      - stress-ng
-      - python3-gi
-      - gir1.2-gudev-1.0
-      #- wget
-      - jq
+      - bc
+      - bonnie++
       - dmidecode
-      - kmod
-      - ipmitool
       - ethtool
+      - fswebcam
+      # - fwts # please include from upstream part
+      - gir1.2-cheese-3.0
+      - gir1.2-gudev-1.0
+      - gstreamer1.0-pulseaudio
+      - hdapsd
+      - hdparm
+      - ipmitool
+      - iperf
       - iperf3
+      - iw
+      - jq
+      - kmod
+      - libfdt1
+      - lshw
+      - mesa-utils
+      - net-tools
       - nmap
-      - smartmontools
+      - nux-tools
+      - nvme-cli
+      - obexftp
       - pciutils
+      - pulseaudio-utils
+      - pyotherside
+      - python3-dbus
+      - python3-gi
+      - python3-yaml
+      - qml-module-qtquick-controls
+      - qml-module-qtquick-layouts
+      - qmlscene
+      - smartmontools
+      - stress-ng
+      - usbutils
+      - util-linux
       - uuid-runtime
-      - bc
+      - wmctrl