Merge ~jocave/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:server-stage-packages into ~checkbox-dev/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: dab7e397463a01dfd6fe27fe0d852c3e4248981f
Merged at revision: 7688ade7f749f273059b93706af56a9e8c6ebfa7
Proposed branch: ~jocave/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:server-stage-packages
Merge into: ~checkbox-dev/plainbox-provider-checkbox/+git/plainbox-provider-checkbox-parts:master
Diff against target: 19 lines (+3/-1)
1 file modified
snapcraft.yaml (+3/-1)
Reviewer Review Type Date Requested Status
Paul Larson Approve
Review via email: mp+325934@code.launchpad.net

Description of the change

stage-packages added to support tests used in the server certification test plans

To post a comment you must log in.
Revision history for this message
Paul Larson (pwlars) wrote :

It seems reasonable, but I'm curious about this history of why all these things in that snapcraft.yaml are commented out? fwts for one, but there are several others as well. Was there some problem caused with them? Otherwise +1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :

Good question. It was really just because I started the list with the stage-packages from plainbox-provider-snappy commented out and re-enabled them as I hit the need for them in this provider. It was basically just for expediency on my part. Given this is still WIP it felt reasonable to leave them there for now.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index c8a8665..6407b53 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -13,7 +13,7 @@ parts:
6 stage-packages:
7 #- python3-yaml
8 - usbutils
9- #- fwts
10+ - fwts
11 - lshw
12 #- bluez-tests
13 - python3-dbus
14@@ -30,3 +30,5 @@ parts:
15 - ethtool
16 - iperf3
17 - nmap
18+ - smartmontools
19+ - pciutils

Subscribers

People subscribed via source and target branches