Merge ~jocave/plainbox-provider-certification-client:odm-cert-streamline into plainbox-provider-certification-client:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: aafbd0dcf90a635be54a6914d726e0fd60d387d8
Merged at revision: 226825fa0319c1a8437cdc86a4c6b51f28d351f2
Proposed branch: ~jocave/plainbox-provider-certification-client:odm-cert-streamline
Merge into: plainbox-provider-certification-client:master
Diff against target: 197 lines (+81/-13)
4 files modified
units/client-cert-odm-desktop-18-04.pxu (+38/-5)
units/client-cert-odm-desktop-20-04.pxu (+39/-6)
units/client-cert-odm-ubuntucore-18.pxu (+2/-1)
units/client-cert-odm-ubuntucore-20.pxu (+2/-1)
Reviewer Review Type Date Requested Status
Chris Wayne (community) Approve
Review via email: mp+389012@code.launchpad.net

Description of the change

Some simplifications to the ODM Cert test plans, these test are more geared toward laptop testing and so feel superfluous to this programme.

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

I'd let git store the history of removals. I cannot +1 it with a clean conscience

Revision history for this message
Chris Wayne (cwayne) wrote :

Lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/client-cert-odm-desktop-18-04.pxu b/units/client-cert-odm-desktop-18-04.pxu
2index 90b5fe0..3dffba7 100644
3--- a/units/client-cert-odm-desktop-18-04.pxu
4+++ b/units/client-cert-odm-desktop-18-04.pxu
5@@ -25,8 +25,8 @@ nested_part:
6 networking-cert-full
7 optical-cert-full
8 power-management-precheck-cert
9- touchpad-cert-full
10- touchscreen-cert-full
11+ # touchpad-cert-full
12+ # touchscreen-cert-full
13 usb-cert-full
14 usb3-cert-full
15 usb-c-cert-full
16@@ -50,8 +50,8 @@ nested_part:
17 after-suspend-led-cert-full
18 after-suspend-mediacard-cert-full
19 after-suspend-optical-cert-full
20- after-suspend-touchpad-cert-full
21- after-suspend-touchscreen-cert-full
22+ # after-suspend-touchpad-cert-full
23+ # after-suspend-touchscreen-cert-full
24 after-suspend-usb-cert-full
25 after-suspend-usb3-cert-full
26 after-suspend-usb-c-cert-full
27@@ -77,4 +77,37 @@ nested_part:
28 tpm2.0_3.0.4
29 info-attachment-cert-full
30 exclude:
31- com.canonical.certification::keys/hibernate
32\ No newline at end of file
33+ com.canonical.certification::keys/hibernate
34+ com.canonical.certification::keys/lock-screen
35+ com.canonical.certification::keys/brightness
36+ com.canonical.certification::keys/media-control
37+ com.canonical.certification::keys/mute
38+ com.canonical.certification::keys/volume
39+ com.canonical.certification::keys/video-out
40+ com.canonical.certification::keys/wireless
41+ com.canonical.certification::keys/keyboard-backlight
42+ com.canonical.certification::keys/microphone-mute
43+ com.canonical.certification::keys/fn-lock
44+ com.canonical.certification::after-suspend-manual-keys/hibernate
45+ com.canonical.certification::after-suspend-manual-keys/lock-screen
46+ com.canonical.certification::after-suspend-manual-keys/brightness
47+ com.canonical.certification::after-suspend-manual-keys/media-control
48+ com.canonical.certification::after-suspend-manual-keys/mute
49+ com.canonical.certification::after-suspend-manual-keys/volume
50+ com.canonical.certification::after-suspend-manual-keys/video-out
51+ com.canonical.certification::after-suspend-manual-keys/wireless
52+ com.canonical.certification::after-suspend-manual-keys/keyboard-backlight
53+ com.canonical.certification::after-suspend-manual-keys/microphone-mute
54+ com.canonical.certification::after-suspend-manual-keys/fn-lock
55+ com.canonical.certification::led/bluetooth
56+ com.canonical.certification::led/wlan
57+ com.canonical.certification::led/wlan-disabled
58+ com.canonical.certification::led/fn
59+ com.canonical.certification::led/mute
60+ com.canonical.certification::led/microphone-mute
61+ com.canonical.certification::suspend/led_after_suspend/bluetooth
62+ com.canonical.certification::suspend/led_after_suspend/wlan
63+ com.canonical.certification::suspend/led_after_suspend/wlan-disabled
64+ com.canonical.certification::after-suspend-manual-led/fn
65+ com.canonical.certification::after-suspend-manual-led/mute
66+ com.canonical.certification::after-suspend-manual-led/microphone-mute
67diff --git a/units/client-cert-odm-desktop-20-04.pxu b/units/client-cert-odm-desktop-20-04.pxu
68index 1fa781d..8aef968 100644
69--- a/units/client-cert-odm-desktop-20-04.pxu
70+++ b/units/client-cert-odm-desktop-20-04.pxu
71@@ -18,7 +18,7 @@ nested_part:
72 monitor-discrete-gpu-cert-full
73 input-cert-full
74 disk-cert-manual
75- fingerprint-full
76+ # fingerprint-full
77 keys-cert-full
78 led-cert-full
79 mediacard-cert-full
80@@ -26,8 +26,8 @@ nested_part:
81 networking-cert-full
82 optical-cert-full
83 power-management-precheck-cert
84- touchpad-cert-full
85- touchscreen-cert-full
86+ # touchpad-cert-full
87+ # touchscreen-cert-full
88 usb-cert-full
89 usb3-cert-full
90 usb-c-cert-full
91@@ -50,8 +50,8 @@ nested_part:
92 after-suspend-led-cert-full
93 after-suspend-mediacard-cert-full
94 after-suspend-optical-cert-full
95- after-suspend-touchpad-cert-full
96- after-suspend-touchscreen-cert-full
97+ # after-suspend-touchpad-cert-full
98+ # after-suspend-touchscreen-cert-full
99 after-suspend-usb-cert-full
100 after-suspend-usb3-cert-full
101 after-suspend-usb-c-cert-full
102@@ -68,7 +68,7 @@ nested_part:
103 cpu-cert-full
104 disk-cert-automated
105 stress-iperf3-automated
106- #stress-cert-full
107+ # stress-cert-full
108 stress-suspend-30-cycles-with-reboots-automated
109 stress-ng-cert-automated
110 stress-30-reboot-poweroff-automated
111@@ -77,3 +77,36 @@ nested_part:
112 info-attachment-cert-full
113 exclude:
114 com.canonical.certification::keys/hibernate
115+ com.canonical.certification::keys/lock-screen
116+ com.canonical.certification::keys/brightness
117+ com.canonical.certification::keys/media-control
118+ com.canonical.certification::keys/mute
119+ com.canonical.certification::keys/volume
120+ com.canonical.certification::keys/video-out
121+ com.canonical.certification::keys/wireless
122+ com.canonical.certification::keys/keyboard-backlight
123+ com.canonical.certification::keys/microphone-mute
124+ com.canonical.certification::keys/fn-lock
125+ com.canonical.certification::after-suspend-manual-keys/hibernate
126+ com.canonical.certification::after-suspend-manual-keys/lock-screen
127+ com.canonical.certification::after-suspend-manual-keys/brightness
128+ com.canonical.certification::after-suspend-manual-keys/media-control
129+ com.canonical.certification::after-suspend-manual-keys/mute
130+ com.canonical.certification::after-suspend-manual-keys/volume
131+ com.canonical.certification::after-suspend-manual-keys/video-out
132+ com.canonical.certification::after-suspend-manual-keys/wireless
133+ com.canonical.certification::after-suspend-manual-keys/keyboard-backlight
134+ com.canonical.certification::after-suspend-manual-keys/microphone-mute
135+ com.canonical.certification::after-suspend-manual-keys/fn-lock
136+ com.canonical.certification::led/bluetooth
137+ com.canonical.certification::led/wlan
138+ com.canonical.certification::led/wlan-disabled
139+ com.canonical.certification::led/fn
140+ com.canonical.certification::led/mute
141+ com.canonical.certification::led/microphone-mute
142+ com.canonical.certification::suspend/led_after_suspend/bluetooth
143+ com.canonical.certification::suspend/led_after_suspend/wlan
144+ com.canonical.certification::suspend/led_after_suspend/wlan-disabled
145+ com.canonical.certification::after-suspend-manual-led/fn
146+ com.canonical.certification::after-suspend-manual-led/mute
147+ com.canonical.certification::after-suspend-manual-led/microphone-mute
148diff --git a/units/client-cert-odm-ubuntucore-18.pxu b/units/client-cert-odm-ubuntucore-18.pxu
149index dbea39d..00709bc 100644
150--- a/units/client-cert-odm-ubuntucore-18.pxu
151+++ b/units/client-cert-odm-ubuntucore-18.pxu
152@@ -43,7 +43,6 @@ nested_part:
153 mediacard-full
154 rtc-full
155 serial-full
156- snappy-snap-full
157 usb-c-full
158 usb-full
159 usb3-full
160@@ -56,6 +55,7 @@ nested_part:
161 i2c-full
162 memory-automated
163 networking-automated
164+ snappy-snap-automated
165 wireless-automated
166 wireless-wifi-master-mode-auto
167 tpm2.0_3.0.4
168@@ -76,3 +76,4 @@ exclude:
169 mediacard/ms-.*
170 mediacard/msp-.*
171 mediacard/xd-.*
172+ rtc/battery
173diff --git a/units/client-cert-odm-ubuntucore-20.pxu b/units/client-cert-odm-ubuntucore-20.pxu
174index 0aedf72..97e79cb 100644
175--- a/units/client-cert-odm-ubuntucore-20.pxu
176+++ b/units/client-cert-odm-ubuntucore-20.pxu
177@@ -43,7 +43,6 @@ nested_part:
178 mediacard-full
179 rtc-full
180 serial-full
181- snappy-snap-full
182 usb-c-full
183 usb-full
184 usb3-full
185@@ -56,6 +55,7 @@ nested_part:
186 i2c-full
187 memory-automated
188 networking-automated
189+ snappy-snap-automated
190 wireless-automated
191 wireless-wifi-master-mode-auto
192 tpm2.0_4.1.1-automated
193@@ -76,3 +76,4 @@ exclude:
194 mediacard/ms-.*
195 mediacard/msp-.*
196 mediacard/xd-.*
197+ rtc/battery

Subscribers

People subscribed via source and target branches