Merge ~jocave/checkbox-ng:remote-sa-app-blob into checkbox-ng:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: ba67c40f03536bd649411a8ef1f8d5c396902daa
Merged at revision: dd23ff616bdc33cb82b2557e859f140a0f89748a
Proposed branch: ~jocave/checkbox-ng:remote-sa-app-blob
Merge into: checkbox-ng:master
Diff against target: 14 lines (+3/-0)
1 file modified
plainbox/impl/session/remote_assistant.py (+3/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Maciej Kisielewski Approve
Review via email: mp+383288@code.launchpad.net

Description of the change

When using remote in an interactive session, allow a report to be submitted to the submission-service including the description provided at the console on the master.

This currently does not work because the transport creation code tries to update the app_blob using the session assistant - simplest solution was just to pass this through from the remote assistant to slave assistant.

lp:1855629

To post a comment you must log in.
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Nice catch, nice fix. +1

review: Approve
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/plainbox/impl/session/remote_assistant.py b/plainbox/impl/session/remote_assistant.py
2index 4c0a379..363dd1c 100644
3--- a/plainbox/impl/session/remote_assistant.py
4+++ b/plainbox/impl/session/remote_assistant.py
5@@ -181,6 +181,9 @@ class RemoteSessionAssistant():
6 def config(self):
7 return self._sa.config
8
9+ def update_app_blob(self, app_blob):
10+ self._sa.update_app_blob(app_blob)
11+
12 def allowed_when(*states):
13 def wrap(f):
14 def fun(self, *args):

Subscribers

People subscribed via source and target branches