Merge lp:~jobinau/drizzle/reviews into lp:~drizzle-trunk/drizzle/development

[Jobin Augustine]

This is a fix for Warning as Error bug 537880.
GCC optimization -Os gives a strong warning (Error) that _mi_seq_search is retuning flag which is not initialized.
other replacement search functions _mi_prefix_search,_mi_seq_search are initializing their return flag as "0".
so this patch initializes flag in _mi_seq_search to "0".

This was the only obstacle to achive -Os optimization in GCC.

[Jay Pipes (jaypipes)]

Hi Jobin!

Good for you getting your feet wet with the code base! :)

One tiny thing, though...we use no space before and one space after the assignment operator, so you should change:

int flag=0;

to int flag= 0;

I know, I know, I'm being strict on code style! Here is the coding guidelines:

http://drizzle.org/wiki/Coding_Standards

Cheers and welcome to the contributor community!

Jay

review: Needs Fixing

[Monty Taylor (mordred)]

Fantastic.

I'm going to be mean and say that this needs fixing. Drizzle Style Guidelines say that there should be a space after the = but not before.

HOWEVER - this is great. Thanks!

review: Needs Fixing

[Jobin Augustine (jobinau)]

Thank you Jay and Monty for your kind review comments.
Yes Jay, my first patch request. :)
I will fix that and submit again.
Since i am using bzr to this extend first time, I am bit slow. please bear
with me.

[lp:~jobinau/drizzle/reviews]

1407. By jobin <jobin@jobin-laptop> on 2010-03-26

correcting for the coding standard for the ealier fix

1408. By jobin <jobin@jobin-laptop> on 2010-03-26

modified for the coding standard

[Monty Taylor (mordred)]

Wonderful! Looks great. Thanks!

review: Approve

[Jay Pipes (jaypipes)]

review: Approve

=== modified file 'plugin/myisam/mi_search.cc'
--- plugin/myisam/mi_search.cc	2010-02-04 08:14:46 +0000
+++ plugin/myisam/mi_search.cc	2010-03-26 19:41:36 +0000
@@ -175,7 +175,7 @@
 {
   (void)buff;
   register int start,mid,end,save_end;
-  int flag;
+  int flag= 0;
   uint32_t totlength,nod_flag,not_used[2];
 
   totlength=keyinfo->keylength+(nod_flag=mi_test_if_nod(page));
@@ -234,7 +234,7 @@
                    unsigned char *key, uint32_t key_len, uint32_t comp_flag, unsigned char **ret_pos,
                    unsigned char *buff, bool *last_key)
 {
-  int flag=0;
+  int flag= 0;
   uint32_t nod_flag,length=0,not_used[2];
   unsigned char t_buff[MI_MAX_KEY_BUFF],*end;