Merge ~joalif/ubuntu/+source/crash:lp1919275-focal into ubuntu/+source/crash:ubuntu/focal-devel

Proposed by Ioanna Alifieraki
Status: Needs review
Proposed branch: ~joalif/ubuntu/+source/crash:lp1919275-focal
Merge into: ubuntu/+source/crash:ubuntu/focal-devel
Diff against target: 70 lines (+49/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/0003-arm64-Change-tcr_el1_t1sz-variable-name-to-TCR_EL1_T.patch (+41/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Thadeu Lima de Souza Cascardo Pending
git-ubuntu developers Pending
Review via email: mp+401232@code.launchpad.net

Description of the change

This is an MR to address lp #1919275 on focal.
Consists of 2 commits, the first is the actual patch in the form of quilt patch,
the second is the changelog update.

To post a comment you must log in.

Unmerged commits

421b588... by Ioanna Alifieraki

Update changelog

9ba526b... by Ioanna Alifieraki

Patch for LP #1919275

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index d49bbca..38a2a1b 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+crash (7.2.8-1ubuntu1.20.04.1) focal; urgency=medium
7+
8+ * Fix cannot determine VA_BITS_ACTUAL (LP: #1919275):
9+ - d/p/0003-arm64-Change-tcr_el1_t1sz-variable-name-to-TCR_EL1_T.patch
10+
11+ -- Ioanna Alifieraki <ioanna-maria.alifieraki@canonical.com> Thu, 15 Apr 2021 12:33:46 +0300
12+
13 crash (7.2.8-1ubuntu1) focal; urgency=low
14
15 * Merge from Debian unstable. Remaining changes:
16diff --git a/debian/patches/0003-arm64-Change-tcr_el1_t1sz-variable-name-to-TCR_EL1_T.patch b/debian/patches/0003-arm64-Change-tcr_el1_t1sz-variable-name-to-TCR_EL1_T.patch
17new file mode 100644
18index 0000000..0505f75
19--- /dev/null
20+++ b/debian/patches/0003-arm64-Change-tcr_el1_t1sz-variable-name-to-TCR_EL1_T.patch
21@@ -0,0 +1,41 @@
22+From 1c45cea02df7f947b4296c1dcaefa1024235ef10 Mon Sep 17 00:00:00 2001
23+From: Bhupesh Sharma <bhsharma@redhat.com>
24+Origin: upstream, https://github.com/crash-utility/crash/commit/1c45cea02df7f947b4296c1dcaefa1024235ef10
25+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1919275
26+Date: Tue, 14 Jul 2020 01:14:49 +0530
27+Subject: [PATCH] arm64: Change tcr_el1_t1sz variable name to TCR_EL1_T1SZ
28+
29+Since linux kernel commit bbdbc11804ff ("arm64/crash_core: Export
30+TCR_EL1.T1SZ in vmcoreinfo") [available in linux-next now], the name
31+of tcr_el1_t1sz vmcoreinfo variable has been changed to TCR_EL1_T1SZ.
32+
33+Make a similar change in crash-utility.
34+
35+Signed-off-by: Bhupesh Sharma <bhsharma@redhat.com>
36+---
37+ arm64.c | 2 +-
38+ netdump.c | 2 +-
39+ 2 files changed, 2 insertions(+), 2 deletions(-)
40+
41+--- a/arm64.c
42++++ b/arm64.c
43+@@ -3873,7 +3873,7 @@ arm64_calc_VA_BITS(void)
44+ } else if (ACTIVE())
45+ error(FATAL, "cannot determine VA_BITS_ACTUAL: please use /proc/kcore\n");
46+ else {
47+- if ((string = pc->read_vmcoreinfo("NUMBER(tcr_el1_t1sz)"))) {
48++ if ((string = pc->read_vmcoreinfo("NUMBER(TCR_EL1_T1SZ)"))) {
49+ /* See ARMv8 ARM for the description of
50+ * TCR_EL1.T1SZ and how it can be used
51+ * to calculate the vabits_actual
52+--- a/netdump.c
53++++ b/netdump.c
54+@@ -1887,7 +1887,7 @@ vmcoreinfo_read_string(const char *key)
55+ sprintf(value, "%ld", nd->arch_data2 & 0xffffffff);
56+ return value;
57+ }
58+- if (STREQ(key, "NUMBER(tcr_el1_t1sz)") && nd->arch_data2) {
59++ if (STREQ(key, "NUMBER(TCR_EL1_T1SZ)") && nd->arch_data2) {
60+ value = calloc(VADDR_PRLEN+1, sizeof(char));
61+ sprintf(value, "%lld", ((ulonglong)nd->arch_data2 >> 32) & 0xffffffff);
62+ pc->read_vmcoreinfo = no_vmcoreinfo;
63diff --git a/debian/patches/series b/debian/patches/series
64index 439564c..92e7031 100644
65--- a/debian/patches/series
66+++ b/debian/patches/series
67@@ -1,2 +1,3 @@
68 0001-dont-git-clone-eppic-extension.patch
69 0002-multiarch-libc.patch
70+0003-arm64-Change-tcr_el1_t1sz-variable-name-to-TCR_EL1_T.patch

Subscribers

People subscribed via source and target branches