Merge ~jneo8/charm-local-users:docs/discourse into charm-local-users:main

Proposed by JamesLin
Status: Merged
Approved by: Ramesh Sattaru
Approved revision: 58b633b47f493ef96ae4762a21f6695d0adc58ab
Merged at revision: e510c156ce7ffab1df674c0afd9631a166eb8ecc
Proposed branch: ~jneo8/charm-local-users:docs/discourse
Merge into: charm-local-users:main
Diff against target: 50 lines (+2/-7)
4 files modified
charmcraft.yaml (+0/-4)
dev/null (+0/-1)
metadata.yaml (+1/-0)
tests/functional/tests/tests.yaml (+1/-2)
Reviewer Review Type Date Requested Status
Ramesh Sattaru (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Eric Chen Approve
Review via email: mp+448857@code.launchpad.net

Commit message

Add discourse doc link in metadata and drop bionic support

Description of the change

docs: Add discourse doc link in metadata
build: Remove empty actions.yaml
build: Drop bionic support

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tianqi Xiao (txiao) wrote :

The code format in the discourse page is not consistent somehow. Some `juju` are highlighted in green where others are not. And `local` is bold in one of the code blocks. I checked the raw text but didn't see any abnormalities, so not sure why this is happening. Could you please take a look?

Revision history for this message
Eric Chen (eric-chen) wrote :

1. Remove "Description" sub-title
2. Link of "Contribution.md" is invalid

review: Needs Fixing
Revision history for this message
JamesLin (jneo8) wrote :

> The code format in the discourse page is not consistent somehow. Some `juju` are highlighted in green where others are not. And `local` is bold in one of the code blocks. I checked the raw text but didn't see any abnormalities, so not sure why this is happening. Could you please take a look?

Fixed after add *bash* as code highlight.

> 1. Remove "Description" sub-title
> 2. Link of "Contribution.md" is invalid

Updated

Revision history for this message
JamesLin (jneo8) wrote (last edit ):

The functinoal test fail because

```
2023-08-11 06:47:47 WARNING unit.local-users/0.install logger.go:60 Traceback (most recent call last):
2023-08-11 06:47:47 WARNING unit.local-users/0.install logger.go:60 File "./src/charm.py", line 21, in <module>
2023-08-11 06:47:47 WARNING unit.local-users/0.install logger.go:60 from ops.charm import CharmBase
2023-08-11 06:47:47 WARNING unit.local-users/0.install logger.go:60 File "/var/lib/juju/agents/unit-local-users-0/charm/venv/ops/__init__.py", line 170, in <module>
2023-08-11 06:47:47 WARNING unit.local-users/0.install logger.go:60 from . import pebble # type: ignore # noqa: F401
2023-08-11 06:47:47 WARNING unit.local-users/0.install logger.go:60 File "/var/lib/juju/agents/unit-local-users-0/charm/venv/ops/pebble.py", line 68, in <module>
2023-08-11 06:47:47 WARNING unit.local-users/0.install logger.go:60 ServiceDict = typing.TypedDict('ServiceDict',
2023-08-11 06:47:47 WARNING unit.local-users/0.install logger.go:60 AttributeError: module 'typing' has no attribute 'TypedDict'
```

Noted: TypedDict is added to typing in python3.8

So we need to downgrade to the opt version which doesn't have TypedDict to support Bionic(python 3.6.9).

Revision history for this message
Eric Chen (eric-chen) wrote :

LGTM, wait for the result from Jenkins

review: Approve
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ramesh Sattaru (rameshcan) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision e510c156ce7ffab1df674c0afd9631a166eb8ecc

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/actions.yaml b/actions.yaml
2deleted file mode 100644
3index 74a77a5..0000000
4--- a/actions.yaml
5+++ /dev/null
6@@ -1 +0,0 @@
7-# This charm doesn't support any actions
8diff --git a/charmcraft.yaml b/charmcraft.yaml
9index bbab054..34438c4 100644
10--- a/charmcraft.yaml
11+++ b/charmcraft.yaml
12@@ -16,7 +16,3 @@ bases:
13 channel: "20.04"
14 architectures:
15 - amd64
16- - name: ubuntu
17- channel: "18.04"
18- architectures:
19- - amd64
20diff --git a/metadata.yaml b/metadata.yaml
21index bec299b..2180d5d 100644
22--- a/metadata.yaml
23+++ b/metadata.yaml
24@@ -5,6 +5,7 @@ description: |
25 This charm can be deployed alongside prinicpal charms to create and manage
26 local user accounts and groups.
27 summary: A subordinate charm for creating and managing local user accounts and groups on principal units.
28+docs: https://discourse.charmhub.io/t/local-users-docs-index/11340
29 subordinate: true
30 requires:
31 general-info:
32diff --git a/tests/functional/tests/tests.yaml b/tests/functional/tests/tests.yaml
33index 6f8af3e..004de84 100644
34--- a/tests/functional/tests/tests.yaml
35+++ b/tests/functional/tests/tests.yaml
36@@ -2,7 +2,6 @@ charm_name: local-users
37 gate_bundles:
38 - jammy
39 - focal
40- - bionic
41 dev_bundles:
42 - jammy
43 tests:
44@@ -13,4 +12,4 @@ target_deploy_status:
45 workload-status-message-regex: "^$"
46 ubuntu:
47 workload-status: active
48- workload-status-message-regex: "^$"
49\ No newline at end of file
50+ workload-status-message-regex: "^$"

Subscribers

People subscribed via source and target branches

to all changes: