Merge lp:~jml/testtools/wrap-result-in-concurrent-suite into lp:~testtools-committers/testtools/trunk

Proposed by Jonathan Lange
Status: Merged
Merged at revision: 251
Proposed branch: lp:~jml/testtools/wrap-result-in-concurrent-suite
Merge into: lp:~testtools-committers/testtools/trunk
Diff against target: 0 lines
To merge this branch: bzr merge lp:~jml/testtools/wrap-result-in-concurrent-suite
Reviewer Review Type Date Requested Status
testtools committers Pending
Review via email: mp+101902@code.launchpad.net

Description of the change

From talking with Benji, it looks like they need to be able to wrap up the per-thread results in ConcurrentTestSuite so that they can tag the tests in those results. This branch adds a hook.

I'm not 100% convinced by this change. I think that perhaps the only valid use is (once https://code.launchpad.net/~jml/testtools/tagger/+merge/101904 is merged) to do this::

    def _wrap_result(self, per_thread_result, thread_number):
        return Tagger(per_thread_result, set(['thread-%s' % (thread_number,)]), set())

And so we might as well do that. On the other hand, the approach in this branch feels a little more "small pieces, loosely joined".

To post a comment you must log in.
253. By Jonathan Lange

pyflakes

254. By Jonathan Lange

Parametrize wrap_result, rather than relying on inheritance.

255. By Jonathan Lange

Better docs

Preview Diff

Empty

Subscribers

People subscribed via source and target branches