Merge lp:~jml/python-fixtures/upcall-tweak into lp:~python-fixtures/python-fixtures/trunk

Proposed by Jonathan Lange
Status: Merged
Approved by: Robert Collins
Approved revision: 30
Merged at revision: 41
Proposed branch: lp:~jml/python-fixtures/upcall-tweak
Merge into: lp:~python-fixtures/python-fixtures/trunk
Diff against target: 31 lines (+5/-5)
1 file modified
lib/fixtures/_fixtures/environ.py (+5/-5)
To merge this branch: bzr merge lp:~jml/python-fixtures/upcall-tweak
Reviewer Review Type Date Requested Status
Robert Collins Approve
Review via email: mp+80819@code.launchpad.net

Description of the change

This just changes the direct upcall to use super(), as per bug 881120.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/fixtures/_fixtures/environ.py'
2--- lib/fixtures/_fixtures/environ.py 2010-10-17 09:45:38 +0000
3+++ lib/fixtures/_fixtures/environ.py 2011-10-31 16:32:26 +0000
4@@ -1,12 +1,12 @@
5 # fixtures: Fixtures with cleanups for testing and convenience.
6 #
7-# Copyright (c) 2010, Robert Collins <robertc@robertcollins.net>
8-#
9+# Copyright (c) 2010, 2011, Robert Collins <robertc@robertcollins.net>
10+#
11 # Licensed under either the Apache License, Version 2.0 or the BSD 3-clause
12 # license at the users choice. A copy of both licenses are available in the
13 # project source as Apache-2.0 and BSD. You may not use this file except in
14 # compliance with one of these two licences.
15-#
16+#
17 # Unless required by applicable law or agreed to in writing, software
18 # distributed under these licenses is distributed on an "AS IS" BASIS, WITHOUT
19 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
20@@ -38,9 +38,9 @@
21 Fixture.__init__(self)
22 self.varname = varname
23 self.newvalue = newvalue
24-
25+
26 def setUp(self):
27- Fixture.setUp(self)
28+ super(EnvironmentVariableFixture, self).setUp()
29 varname = self.varname
30 orig_value = os.environ.get(varname)
31 if orig_value is not None:

Subscribers

People subscribed via source and target branches