Merge lp:~jml/pocket-lint/singleton-tuples into lp:pocket-lint
Proposed by
Jonathan Lange
on 2010-10-01
| Status: | Merged |
|---|---|
| Approved by: | Curtis Hovey on 2010-10-01 |
| Approved revision: | 323 |
| Merged at revision: | 323 |
| Proposed branch: | lp:~jml/pocket-lint/singleton-tuples |
| Merge into: | lp:pocket-lint |
| Diff against target: |
10 lines (+2/-0) 1 file modified
pocketlint/contrib/pep8.py (+2/-0) |
| To merge this branch: | bzr merge lp:~jml/pocket-lint/singleton-tuples |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey | code | 2010-10-01 | Approve on 2010-10-01 |
|
Review via email:
|
|||
Commit Message
Do not warn about valid singleton tuples.
Description of the Change
pep8.py warns about singleton tuples written like (foo,). It should not. This branch fixes that.
No tests, since I couldn't find any. I tested by running contrib/pep8.py against a file with the contents:
foo = (123,)
To post a comment you must log in.
| Jonathan Lange (jml) wrote : | # |
On Fri, Oct 1, 2010 at 2:03 PM, Curtis Hovey <email address hidden> wrote:
> Review: Approve code
> Thanks for the patch. Should this go upstream?
Probably. I don't know where official upstream is.
jml
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the patch. Should this go upstream?