Merge lp:~jml/pkgme/pickleable-exceptions into lp:pkgme

[Jonathan Lange]

Turns out that celery pickles exceptions, and that you need to pass arguments to the parent classes in order to have exceptions pickle and unpickle successfully. Pickling is important for getting full error messages out of the tasks. In particular, the custom logic that we used to show the output from failed pkgme scripts wasn't getting used until I applied this patch.

http://celery.readthedocs.org/en/latest/userguide/tasks.html#creating-pickleable-exceptions

=== modified file 'pkgme/run_script.py'
--- pkgme/run_script.py	2011-10-31 16:18:41 +0000
+++ pkgme/run_script.py	2011-11-23 14:31:37 +0000
@@ -9,15 +9,15 @@
 
 class ScriptProblem(PkgmeError):
 
-    def __init__(self, script_path):
-        super(ScriptProblem, self).__init__()
+    def __init__(self, script_path, *args):
+        super(ScriptProblem, self).__init__(script_path, *args)
         self.script_path = script_path
 
 
 class ScriptMissing(ScriptProblem):
 
-    def __init__(self, script_path):
-        super(ScriptMissing, self).__init__(script_path)
+    def __init__(self, script_path, *args):
+        super(ScriptMissing, self).__init__(script_path, *args)
 
     def __str__(self):
         return "%s not found" % (self.script_path, )
@@ -26,18 +26,18 @@
 class ScriptPermissionDenied(ScriptProblem):
     """Attempting to run a script led to a permission denied error."""
 
-    def __init__(self, script_path):
-        super(ScriptPermissionDenied, self).__init__(script_path)
+    def __init__(self, script_path, *args):
+        super(ScriptPermissionDenied, self).__init__(script_path, *args)
 
     def __str__(self):
-        return ("permission denied trying to execute %s, is it executable?" 
+        return ("permission denied trying to execute %s, is it executable?"
                 % (self.script_path, ))
 
 
 class ScriptFailed(ScriptProblem):
 
     def __init__(self, command, returncode, output_lines):
-        super(ScriptFailed, self).__init__(command[0])
+        super(ScriptFailed, self).__init__(command, returncode, output_lines)
         self.command = command
         self.returncode = returncode
         self.output_lines = output_lines