Merge lp:~jml/pkgme-devportal/delete-lp-cache into lp:pkgme-devportal

[Jonathan Lange]

Delete launchpadlib cache after fetching symbols.

I ran the package importer overnight using pkgme-binary to import binary packages. I hit the disk usage limit, as for every package it would create a temporary directory for the launchpadlib cache to avoid dependency issues, but it would never delete that directory. Each of the directories was 1.5MB, so this quickly hit the ~7G disk size.

This patch turns our launchpadlib acquisition helper into a Fixture, and makes fixtures a direct dependency of pkgme-binary.

[James Westby (james-w)]

Good catch, thanks.

Thanks for taking on the lplib bug as well.

James

review: Approve

=== modified file 'devportalbinary/database.py'
--- devportalbinary/database.py	2012-02-01 17:59:23 +0000
+++ devportalbinary/database.py	2012-03-22 11:56:18 +0000
@@ -29,6 +29,10 @@
         ConfigSection as Section,
         StringConfigOption as StringOption,
         )
+from fixtures import (
+    Fixture,
+    TempDir,
+    )
 
 from launchpadlib import (
     uris,
@@ -52,8 +56,18 @@
 ARCHITECTURES = ('i386', 'all')
 
 
-def get_lp():
-    return Launchpad.login_anonymously(APPLICATION_NAME, SERVICE_ROOT, tempfile.mkdtemp())
+class LaunchpadFixture(Fixture):
+
+    def __init__(self, application_name, service_root):
+        super(LaunchpadFixture, self).__init__()
+        self._app_name = application_name
+        self._service_root = service_root
+
+    def setUp(self):
+        super(LaunchpadFixture, self).setUp()
+        tempdir = self.useFixture(TempDir())
+        self.anonymous = Launchpad.login_anonymously(
+            self._app_name, self._service_root, tempdir.path)
 
 
 def iter_published_sources(lp, since=None, name=None, exact_match=False):
@@ -444,7 +458,8 @@
         finder = BinaryPackage.find
     else:
         finder = SourcePackage.find
-    package = finder(get_lp(), package_name)
+    with LaunchpadFixture(APPLICATION_NAME, SERVICE_ROOT) as lp:
+        package = finder(lp.anonymous, package_name)
     if not package:
         return
     symbols = [

=== modified file 'setup.py'
--- setup.py	2011-12-05 20:34:11 +0000
+++ setup.py	2012-03-22 11:56:18 +0000
@@ -30,6 +30,7 @@
         'configglue',
         'launchpadlib',
         'pkgme',
+        'fixtures',
         'storm',
         ],
     entry_points = {