Merge lp:~jml/launchpadlib/hacking-documentation into lp:launchpadlib

Proposed by Jonathan Lange
Status: Merged
Merged at revision: 119
Proposed branch: lp:~jml/launchpadlib/hacking-documentation
Merge into: lp:launchpadlib
Diff against target: 15 lines (+4/-1)
1 file modified
HACKING.txt (+4/-1)
To merge this branch: bzr merge lp:~jml/launchpadlib/hacking-documentation
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Raphaël Badin (community) code* Approve
Review via email: mp+75520@code.launchpad.net

Description of the change

The HACKING.txt linked to a not-very-useful page on the Launchpad wiki. After being told that there *is* a useful page, I decided to update the documentation here.

To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) :
review: Approve (code*)
Revision history for this message
Robert Collins (lifeless) wrote :

the not very useful page has a link to the useful page, and also talks
about coding style etc. I'm ambivalent about this change at best.

Revision history for this message
Gavin Panella (allenap) :
review: Approve
Revision history for this message
Jonathan Lange (jml) wrote :

On Thu, Sep 15, 2011 at 1:40 PM, Robert Collins
<email address hidden> wrote:
> the not very useful page has a link to the useful page, and also talks
> about coding style etc. I'm ambivalent about this change at best.

The HackingLazrLibraries page links back to Hacking as well. As a
page, Coding style can often be inferred from the surrounding code,
whereas testing, landing and release processes are harder to figure
out.

The Hacking page is full of information that is not at all relevant to
hacking on lazr libraries. (e.g. Storm, Security and Authentication,
Web UI, Celebrities, Launchpad configuration). Having it linked from
HackingLazrLibraries, which becomes the primary landing page for lazr
hacking documents.

jml

Revision history for this message
Jonathan Lange (jml) wrote :

On Thu, Sep 15, 2011 at 1:55 PM, Jonathan Lange <email address hidden> wrote:
> On Thu, Sep 15, 2011 at 1:40 PM, Robert Collins
> <email address hidden> wrote:
>> the not very useful page has a link to the useful page, and also talks
>> about coding style etc. I'm ambivalent about this change at best.
>
> The HackingLazrLibraries page links back to Hacking as well. As a
> page, Coding style can often be inferred from the surrounding code,
> whereas testing, landing and release processes are harder to figure
> out.
>
> The Hacking page is full of information that is not at all relevant to
> hacking on lazr libraries. (e.g. Storm, Security and Authentication,
> Web UI, Celebrities, Launchpad configuration). Having it linked from
> HackingLazrLibraries, which becomes the primary landing page for lazr
> hacking documents....

Oops.

"Having it linked from HackingLazrLibraries, which then becomes the
primary landing page for lazr hacking documents, makes it available as
a reference and more clearly indicates that Hacking is of less direct
relevance."

jml

Revision history for this message
Gavin Panella (allenap) wrote :

Gah, I even read HackingLazrLibraries as I landed it, but somehow forgot to put "Landed on behalf of ..." in the commit message. Earnest apologies, I promise I was not trying to steal the limelight :)

Revision history for this message
Jonathan Lange (jml) wrote :

On Thu, Sep 15, 2011 at 4:23 PM, Gavin Panella
<email address hidden> wrote:
> Gah, I even read HackingLazrLibraries as I landed it, but somehow forgot to put "Landed on behalf of ..." in the commit message. Earnest apologies, I promise I was not trying to steal the limelight :)

No worries :) Just happy to have it landed.

jml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'HACKING.txt'
2--- HACKING.txt 2009-09-28 18:53:10 +0000
3+++ HACKING.txt 2011-09-15 11:02:28 +0000
4@@ -22,7 +22,10 @@
5 These are guidelines for hacking on the lazr.launchpadlib project. But first,
6 please see the common hacking guidelines at:
7
8- http://dev.launchpad.net/Hacking
9+ https://dev.launchpad.net/HackingLazrLibraries
10+
11+These guidelines will tell you how to run the tests, use in-development
12+versions of libraries, land your branches and get them released.
13
14
15 Getting help

Subscribers

People subscribed via source and target branches