Merge lp:~jml/launchpad/tweak-community-contributors into lp:launchpad

Proposed by Jonathan Lange
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: 11059
Proposed branch: lp:~jml/launchpad/tweak-community-contributors
Merge into: lp:launchpad
Diff against target: 83 lines (+19/-5)
1 file modified
utilities/community-contributions.py (+19/-5)
To merge this branch: bzr merge lp:~jml/launchpad/tweak-community-contributors
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+28501@code.launchpad.net

Description of the change

This branch tweaks some of the data that we use to generate https://dev.launchpad.net/Contributions.

In particular:
  * Steve Kowalik is on the Launchpad team
  * James Westby at Linaro is the same person as James Westby at Canonical (don't let the glasses fool you)
  * Didier Roche works for Canonical
  * Bryce, Dustin and Anthony Lenton all had multiple addresses

To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

Oh yeah. Pitti too :)

Also, I guess we can't land this during week 4. There's a rule that helps.

Revision history for this message
Brad Crittenden (bac) wrote :

Hi Jonathan, thanks for updating the lists.

I notice that Martin Pool is in both LP and not-LP lists.

Also should jpds be in the non_lp_devs list or is it ok since he always uses a canonical.com address?

pyflakes (in emacs) shows a few issues. inventory_sha1 is not used. Lots of trailing whitespace, etc.

review: Approve (code)
Revision history for this message
Jonathan Lange (jml) wrote :

Thanks Brad.

Whitespace & flakes fixed. Martin Pool moved to not-LP, jpds unchanged since he always uses a canonical address.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utilities/community-contributions.py'
2--- utilities/community-contributions.py 2010-04-09 13:53:50 +0000
3+++ utilities/community-contributions.py 2010-06-25 13:21:32 +0000
4@@ -162,7 +162,6 @@
5 u'Maris Fogels',
6 u'Mark Shuttleworth',
7 u'Martin Albisetti',
8- u'Martin Pool',
9 u'Matt Zimmerman',
10 u'Matthew Paul Thomas',
11 u'Matthew Thomas',
12@@ -178,6 +177,7 @@
13 u'Robert Collins',
14 u'Stuart Bishop',
15 u'Steve Alexander',
16+ u'Steve Kowalik',
17 u'Steve McInerney',
18 u'<steve {_AT_} stedee.id.au>',
19 u'test {_AT_} canonical.com',
20@@ -200,13 +200,16 @@
21 u'Cody Somerville',
22 u'Cody A.W. Somerville',
23 u'David Murphy',
24+ u'Didier Roche',
25 u'Elliot Murphy',
26 u'Gabriel Neuman gneuman {_AT_} async.com',
27 u'Gustavo Niemeyer',
28 u'James Henstridge',
29+ u'James Westby',
30 u'John Lenton',
31 u'Kees Cook',
32 u'LaMont Jones',
33+ u'Martin Pitt',
34 u'Martin Pool',
35 u'Matt Zimmerman',
36 u'Michael Casadevall',
37@@ -216,7 +219,7 @@
38 u'Dustin Kirkland',
39 )]
40
41-# Some people have made commits using various names and/or email
42+# Some people have made commits using various names and/or email
43 # addresses, so this map will be used to merge them accordingly.
44 # The map is initialized from this list of pairs, where each pair is
45 # of the form (CONTRIBUTOR_AS_SEEN, UNIFYING_IDENTITY_FOR_CONTRIBUTOR).
46@@ -245,6 +248,18 @@
47 u'Adam Conrad <adconrad {_AT_} 0c3.net>'),
48 (u'Adam Conrad <adconrad {_AT_} cthulhu>',
49 u'Adam Conrad <adconrad {_AT_} 0c3.net>'),
50+ (u'James Westby <james.westby@linaro.org>',
51+ u'James Westby <james.westby@canonical.com'),
52+ (u'Bryce Harrington <bryce@canonical.com>',
53+ u'Bryce Harrington <bryce.harrington@canonical.com>'),
54+ (u'Dustin Kirkland <kirkland@x200>',
55+ u'Dustin Kirkland <kirkland@canonical.com>'),
56+ (u'Anthony Lenton <antoniolenton@gmail.com>',
57+ u'Anthony Lenton <anthony.lenton@canonical.com>'),
58+ (u'Steve Kowalik <steven@quelled>',
59+ u'Steve Kowalik <steve.kowalik@canonical.com>'),
60+ (u'Steve Kowalik <stevenk@ubuntu.com>',
61+ u'Steve Kowalik <steve.kowalik@canonical.com>'),
62 )
63 # Then put it in dictionary form with the correct encodings.
64 merge_names_map = dict((wiki_encode(a), wiki_encode(b))
65@@ -274,7 +289,6 @@
66 timezone = self.top_rev.rev.timezone
67 message = self.top_rev.rev.message or "(NO LOG MESSAGE)"
68 rev_id = self.top_rev.rev.revision_id or "(NO REVISION ID)"
69- inventory_sha1 = self.top_rev.rev.inventory_sha1
70 if timestamp:
71 date_str = format_date(timestamp, timezone or 0, 'original')
72 else:
73@@ -325,8 +339,8 @@
74 "\n",
75 ]
76 return ''.join(text)
77-
78-
79+
80+
81 # "ExternalContributor" is too much to type, so I guess we'll just use this.
82 class ExCon():
83 """A contributor to Launchpad from outside Canonical's Launchpad team."""