Merge lp:~jml/launchpad/show-warnings-once into lp:launchpad

[Jonathan Lange]

Only show warnings once at the end of a test run.

It turns out that we blat all over Python's normal warning filtering and show every instance of every warning. This sucks *and* blows at the same time, so I've cobbled together a crappy little hack to fix it.

It's pretty hard to verify that this hack works, so I'm running the branch through ec2 test now.

[Robert Collins (lifeless)]

If it works, rs=me

[Jelmer Vernooij (jelmer)]

Because the warnings include repr()'s this doesn't help in a lot of situations, e.g.:

/var/launchpad/test/lib/lp/soyuz/tests/test_publishing.py:229: ShouldThisBeUsingRemoveSecurityProxy: removeSecurityProxy(<PackageUpload at 0x16f126d0>) called. Is this correct? Either call it directly or fix the test.
  package_upload)

/var/launchpad/test/lib/lp/soyuz/tests/test_publishing.py:229: ShouldThisBeUsingRemoveSecurityProxy: removeSecurityProxy(<PackageUpload at 0x146b2210>) called. Is this correct? Either call it directly or fix the test.
  package_upload)

I guess we should make sure to improve our __repr__ methods to fix more of these.

Either way, it's better than using a list. Should it perhaps be sorted so we see the warnings grouped per file, line?

review: Approve (code)

=== modified file 'lib/lp/scripts/utilities/warninghandler.py'
--- lib/lp/scripts/utilities/warninghandler.py	2010-07-27 13:56:42 +0000
+++ lib/lp/scripts/utilities/warninghandler.py	2010-08-05 15:19:50 +0000
@@ -147,7 +147,9 @@
 
 need_page_titles = []
 no_order_by = []
-other_warnings = []
+
+# Maps (category, filename, lineno) to WarningReport
+other_warnings = {}
 
 old_show_warning = warnings.showwarning
 def launchpad_showwarning(message, category, filename, lineno, file=None,
@@ -177,7 +179,8 @@
                     WarningReport(warning_message, important_info)
                     )
                 return
-    other_warnings.append(WarningReport(warning_message, important_info))
+    other_warnings[(category, filename, lineno)] = WarningReport(
+        warning_message, important_info)
 
 def report_need_page_titles():
     global need_page_titles
@@ -202,7 +205,7 @@
     if other_warnings:
         print
         print "General warnings."
-        for warninginfo in other_warnings:
+        for warninginfo in other_warnings.itervalues():
             print
             print warninginfo