Merge lp:~jml/launchpad/link-to-lp-revision into lp:launchpad

[Jonathan Lange]

This branch changes the footer on edge to link to the Launchpad stable branch.

The way I've done the change is kind of crappy. I welcome suggestions on how to do it better.

[Brad Crittenden (bac)]

Hi Jono,

I don't have any suggestions for doing it better. But I wonder why you want a link to the branch here to the stable branch instead of to the devel branch or even https://dev.launchpad.net/Getting

review: Needs Information (code)

[Jonathan Lange (jml)]

On Fri, Jul 30, 2010 at 3:21 PM, Brad Crittenden <email address hidden> wrote:
> Review: Needs Information code
> Hi Jono,
>
> I don't have any suggestions for doing it better.  But I wonder why you want a link to the branch here to the stable branch instead of to the devel branch or even https://dev.launchpad.net/Getting

The devel branch has very little to do with what's on edge, and is to
my mind merely a convenient mechanism for queueing up changes to the
stable branch. To put it another way, why would we link to broken code
when we can link to a known-good branch?

I don't link to Getting because part of the motivation for the link is
to make it easy to see a revision log. I don't know whether that's a
good enough reason.

Thanks for the review.
jml

[Brad Crittenden (bac)]

review: Approve (code)

=== modified file 'lib/lp/app/templates/base-layout-macros.pt'
--- lib/lp/app/templates/base-layout-macros.pt	2010-07-21 14:20:33 +0000
+++ lib/lp/app/templates/base-layout-macros.pt	2010-07-29 17:47:47 +0000
@@ -428,7 +428,10 @@
         r<tal:revno replace="revno" />
         <tal:devmode condition="devmode">devmode</tal:devmode>
         <tal:demo condition="is_demo">demo site</tal:demo>
-        <tal:edge condition="is_edge">beta site</tal:edge>
+        <tal:edge condition="is_edge">
+          beta site (<a href="https://code.edge.launchpad.net/~launchpad-pqm/launchpad/stable/"
+             >get the code</a>)
+        </tal:edge>
       </span>
     </div>
   </div>