Merge lp:~jml/launchpad/launchbag-test-bug-58 into lp:launchpad

Proposed by Jonathan Lange
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jml/launchpad/launchbag-test-bug-58
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~jml/launchpad/launchbag-test-bug-58
Reviewer Review Type Date Requested Status
Michael Hudson-Doyle Approve
Review via email: mp+11103@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Lange (jml) wrote :

This branch simply adds a test to show that ILaunchBag.user is None when no-one is logged in. It fixes a two-digit bug.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Haha!

review: Approve
Revision history for this message
Tim Penhey (thumper) wrote :

> This branch simply adds a test to show that ILaunchBag.user is None when no-
> one is logged in. It fixes a two-digit bug.

It would be good to update the doctest to follow the new guidelines :)

Revision history for this message
Jonathan Lange (jml) wrote :

On Thu, Sep 3, 2009 at 10:23 AM, Tim Penhey<email address hidden> wrote:
>> This branch simply adds a test to show that ILaunchBag.user is None when no-
>> one is logged in. It fixes a two-digit bug.
>
> It would be good to update the doctest to follow the new guidelines :)

I'd love to, but since there's no clear, up-to-date document
explaining the guidelines, I won't.

https://dev.launchpad.net/TestsStyleGuide is very much out of date,
and has way too much prose for someone trying to figure out correct
indentation & markup.

jml

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/doc/launchbag.txt'
2--- lib/canonical/launchpad/doc/launchbag.txt 2009-05-12 08:10:20 +0000
3+++ lib/canonical/launchpad/doc/launchbag.txt 2009-09-03 00:08:57 +0000
4@@ -57,6 +57,11 @@
5 >>> print launchbag.login
6 None
7
8+'user' will also be set to None:
9+
10+>>> print launchbag.user
11+None
12+
13 Let's do a cookie auth principal identification. In this case, the login
14 will be cookie@example.com.
15