Merge lp:~jml/launchpad/git-and-hg into lp:launchpad
| Status: | Merged |
|---|---|
| Approved by: | Brad Crittenden on 2010-06-25 |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11069 |
| Proposed branch: | lp:~jml/launchpad/git-and-hg |
| Merge into: | lp:launchpad |
| Diff against target: |
32 lines (+5/-6) 2 files modified
lib/lp/code/stories/branches/xx-product-branches.txt (+2/-2) lib/lp/code/templates/product-branch-summary.pt (+3/-4) |
| To merge this branch: | bzr merge lp:~jml/launchpad/git-and-hg |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | 2010-06-25 | Approve on 2010-06-25 |
|
Review via email:
|
|||
Commit Message
On the project page, say that you can import from git and mercurial as well as svn and cvs.
Description of the Change
The branch listing page for a product says that you can import stuff from Subversion and CVS. This is true, but you can also import stuff from git and mercurial as well.
| Robert Collins (lifeless) wrote : | # |
| Jonathan Lange (jml) wrote : | # |
On Fri, Jun 25, 2010 at 9:19 PM, Robert Collins
<email address hidden> wrote:
> Just wanted to mention that it seems a little weird to manually
> enumerate a list that we also have as a selector in the system.
> Couldn't we list-and-stringify?
>
Patches accepted.
jml
| Jonathan Lange (jml) wrote : | # |
On Fri, Jun 25, 2010 at 9:27 PM, Jonathan Lange <email address hidden> wrote:
> On Fri, Jun 25, 2010 at 9:19 PM, Robert Collins
> <email address hidden> wrote:
>> Just wanted to mention that it seems a little weird to manually
>> enumerate a list that we also have as a selector in the system.
>> Couldn't we list-and-stringify?
>>
>
> Patches accepted.
>
Which is to say, you're right and that would be a better approach.
However, I made the trade-off at the time of fixing a simple bug as
soon as I noticed it, and have no personal motivation to continue
improving this particular part of Launchpad right now.
jml
Just wanted to mention that it seems a little weird to manually
enumerate a list that we also have as a selector in the system.
Couldn't we list-and-stringify?
-Rob