Launchpad itself

Merge lp:~jml/launchpad/expose-commercial-on-create-ppa into lp:launchpad

  1. expose-commercial-on-create-ppa
  2. Merge into devel
Proposed by Jonathan Lange on 2012-04-13
Status: Merged
Approved by: Brad Crittenden on 2012-04-13
Approved revision: no longer in the source branch.
Merged at revision: 15115
Proposed branch: lp:~jml/launchpad/expose-commercial-on-create-ppa
Merge into: lp:launchpad
Diff against target: 11 lines (+1/-0)
1 file modified
lib/lp/registry/interfaces/person.py (+1/-0)
To merge this branch: bzr merge lp:~jml/launchpad/expose-commercial-on-create-ppa
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code 2012-04-13 Approve on 2012-04-13
Review via email: mp+101907@code.launchpad.net

Commit Message

Expose the 'commercial' parameter of IPerson.createPPA.

Description of the Change

QA revealed that the 'commercial' parameter on createPPA was not being exposed. This patch exposes it.

I initially tried to force a test failure by adding something to lp/soyuz/stories/webservice/xx-person-createppa.txt that created a commercial PPA. Annoyingly, this test passed, so I deleted it. I couldn't figure out how to get a failing test, so I have just submitted the fix.

To post a comment you must log in.
Brad Crittenden (bac) wrote :

Thanks Jono

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/interfaces/person.py'
2--- lib/lp/registry/interfaces/person.py 2012-04-03 15:34:50 +0000
3+++ lib/lp/registry/interfaces/person.py 2012-04-13 13:45:25 +0000
4@@ -1487,6 +1487,7 @@
5 displayname=TextLine(required=False),
6 description=TextLine(required=False),
7 private=Bool(required=False),
8+ commercial=Bool(required=False),
9 )
10 @export_factory_operation(Interface, []) # Really IArchive.
11 @operation_for_version("beta")