Merge lp:~jml/launchpad/archive-commercial-rename-support into lp:launchpad
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15368 |
Proposed branch: | lp:~jml/launchpad/archive-commercial-rename-support |
Merge into: | lp:launchpad |
Diff against target: |
104 lines (+47/-17) 2 files modified
lib/lp/soyuz/interfaces/archive.py (+0/-8) lib/lp/soyuz/model/archive.py (+47/-9) |
To merge this branch: | bzr merge lp:~jml/launchpad/archive-commercial-rename-support |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+107819@code.launchpad.net |
Commit message
Allow Archive to work with db column named either suppress_
Description of the change
This branch updates the Launchpad code base in preparation for a database patch that will rename Archive.commercial to Archive.
It deletes the commercial field from the class (unused), and changes the suppress_
This approach works because Archive.commercial is never queried on, never used in a WHERE clause.
Other approaches discussed and dismissed were:
* hack Storm to support this somehow (too hard)
* add a new column and have that update with triggers; deploy that; change code to always use new column; deploy that; remove old column and triggers (quite cumbersome)
This branch adds 30 lines of code. This are mostly temporary, as they can be deleted after the rename. Further, we are currently 140 lines in credit on this arc of work anyway. Happy to count those toward that total, leaving us at 110.
Your evil truly knows no bounds.