LightDM GTK Greeter Settings

Merge lp:~jlu5/lightdm-gtk-greeter-settings/reproducible-build into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter-settings/trunk

  1. reproducible-build
  2. Merge into trunk
Proposed by James Lu
Status: Merged
Merged at revision: 71
Proposed branch: lp:~jlu5/lightdm-gtk-greeter-settings/reproducible-build
Merge into: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter-settings/trunk
Diff against target: 14 lines (+2/-2)
1 file modified
setup.py (+2/-2)
To merge this branch: bzr merge lp:~jlu5/lightdm-gtk-greeter-settings/reproducible-build
Reviewer Review Type Date Requested Status
Sean Davis Approve
James Lu Pending
Review via email: mp+292095@code.launchpad.net

This proposal supersedes a proposal from 2016-04-17.

Description of the change

Make builds reproducible. Original Debian bug: http://bugs.debian.org/804081

To post a comment you must log in.
Revision history for this message
Simon Steinbeiß (ochosi) wrote :

Looks like a reasonable change to me, but I'd rather let someone with more python packaging experience have a say.

Revision history for this message
Sean Davis (bluesabre) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2016-04-07 08:59:58 +0000
3+++ setup.py 2016-04-17 20:40:25 +0000
4@@ -34,8 +34,8 @@
5 libdir, 'lightdm_gtk_greeter_settings/installation_config.py')
6 try:
7 f = open(filename, 'w')
8- f.write('__all__ = [%s]\n' % ', '.join('"%s"' % k for k in values))
9- for k, v in values.items():
10+ f.write('__all__ = [%s]\n' % ', '.join('"%s"' % k for k in sorted(values)))
11+ for k, v in sorted(values.items()):
12 f.write('%s = %s\n' % (k, v))
13 except OSError as e:
14 print("ERROR: Can't write installation config: %s" % e)

Subscribers

People subscribed via source and target branches