Merge lp:~jlangvand/ubuntu/quantal/gnome-control-center/fix-for-993440 into lp:ubuntu/quantal/gnome-control-center
Proposed by
Joakim Langvand
on 2012-11-08
| Status: | Rejected |
|---|---|
| Rejected by: | Martin Pitt on 2012-11-23 |
| Proposed branch: | lp:~jlangvand/ubuntu/quantal/gnome-control-center/fix-for-993440 |
| Merge into: | lp:ubuntu/quantal/gnome-control-center |
| Diff against target: |
47 lines (+27/-0) 3 files modified
debian/changelog (+7/-0) debian/patches/power_suspend_on_critical.patch (+19/-0) debian/patches/series (+1/-0) |
| To merge this branch: | bzr merge lp:~jlangvand/ubuntu/quantal/gnome-control-center/fix-for-993440 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Didier Roche | Resubmit on 2012-11-23 | ||
| Ubuntu branches | 2012-11-08 | Pending | |
|
Review via email:
|
|||
Description of the Change
Add "Suspend" as an optional action for critical battery level.
To post a comment you must log in.
Unmerged revisions
- 271. By Joakim Langvand on 2012-11-08
-
* debian/
patches/ power_suspend_ on_critical. patch:
- added suspend as an option for critical battery level (lp: #993440)


Hey Joakim!
Thanks for you patch and help to make ubuntu better :)
We try to not add strings to existing ubuntu release, because they won't be translated. Also, this change the behavior by introducing more options to people on an existing release and the SRU policy is to avoid doing that.
I think this patch may be discussed (can you take it upstream as well?) and should be rebase on raring, which will probably use gnome-control- center 4.6. Do you mind proposing it against lp:~ubuntu-desktop/gnome-control-center/ubuntu? (This is where desktop packaging are handled, see Bzr-Vcs in debian/control pointing to it).
Thanks agian, will reject the branch for now.