Merge lp:~jkakar/txsolr/makefile-787491 into lp:txsolr

Proposed by Jamu Kakar
Status: Merged
Merged at revision: 57
Proposed branch: lp:~jkakar/txsolr/makefile-787491
Merge into: lp:txsolr
Diff against target: 46 lines (+34/-0)
2 files modified
.bzrignore (+2/-0)
Makefile (+32/-0)
To merge this branch: bzr merge lp:~jkakar/txsolr/makefile-787491
Reviewer Review Type Date Requested Status
Terry Jones (community) Approve
Manuel Cerón Approve
Review via email: mp+62105@code.launchpad.net

Description of the change

This branch introduces the following changes:

- A Makefile with some handy targets has been added to the project.

- Files generated by setup.py have been added to Bazaar's ignore list.

To post a comment you must log in.
Revision history for this message
Manuel Cerón (ceronman) wrote :

+1. Nice improvement.

review: Approve
Revision history for this message
Jamu Kakar (jkakar) wrote :

Should we just land this? Not sure it really needs two reviews.

Revision history for this message
Terry Jones (terrycojones) wrote :

I would add --repeat to the pep8 call, to see all errors.

I also find pep8 more reliable if I only give it one file
at a time. So I tend to use

find . -name '*.py' | xargs -n 1 pep8 --repeat

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2010-09-10 22:20:00 +0000
3+++ .bzrignore 2011-05-24 11:18:42 +0000
4@@ -2,3 +2,5 @@
5 .project
6 .settings
7 _trial_temp
8+MANIFEST
9+dist
10
11=== added file 'Makefile'
12--- Makefile 1970-01-01 00:00:00 +0000
13+++ Makefile 2011-05-24 11:18:42 +0000
14@@ -0,0 +1,32 @@
15+clean:
16+ find . -name \*pyc -exec rm {} \;
17+ rm -rf doc
18+ rm -rf _trial_temp
19+
20+check:
21+ trial txsolr
22+
23+info:
24+ @bzr info
25+ @echo
26+ @echo "Revision:"
27+ @bzr revno
28+ @echo
29+ @echo "Lines of application code:"
30+ @find txsolr -name \*py | grep -v test_ | xargs cat | wc -l
31+ @echo
32+ @echo "Lines of test code:"
33+ @find txsolr -name \*py | grep test_ | xargs cat | wc -l
34+
35+lint:
36+ pep8 $(shell find . -name \*py)
37+ pyflakes $(shell find . -name \*py)
38+
39+api:
40+ pydoctor --project-name txSolr \
41+ --make-html \
42+ --html-output doc \
43+ --add-package txsolr
44+
45+release:
46+ python setup.py sdist

Subscribers

People subscribed via source and target branches

to all changes: