Code review comment for lp:~jkakar/subunit/ppa-build

Revision history for this message
Robert Collins (lifeless) wrote :

> This branch adds a debian/ directory to subunit with Debian
> packaging files. It's setup to build the python-subunit package for
> multiple versions of Ubuntu with AutoPPA.
>
> Some things that might need improvement:
>
> 1. In the end I had to symlink python/subunit to subunit, so that
> setuptools could find the package (this happens in setup.py).
> Maybe there's a better way to do this? I Google'd a bit, but
> didn't find anything like a package_root_path or similar that I
> could pass to the setup function.

package_dir = {'':python}

but distutils is heinous for non-python, and subunit is only partially python, which is why it doesn't use a setup.py.
...
> I've installed the hardy package and verified that 'import subunit'
> works in a Python interpreter. Anyway, if the packages built by
> this branch are acceptable I'd like to rebuild and distribute them
> in a subunit-focused PPA.

You're welcome to do that - in fact, if you join the subunit developers team you can use the subunit ppa. I've done somewhat more comprehensive packaging for subunit now though - so this branch is rather stale. We could do with more uploads etc :) I'm sorry that the effort you put in wasn't directly used.

review: Needs Fixing

« Back to merge proposal