Code review comment for lp:~jkakar/subunit/ppa-build

Revision history for this message
Jamu Kakar (jkakar) wrote :

This branch adds a debian/ directory to subunit with Debian
packaging files. It's setup to build the python-subunit package for
multiple versions of Ubuntu with AutoPPA.

Some things that might need improvement:

1. In the end I had to symlink python/subunit to subunit, so that
   setuptools could find the package (this happens in setup.py).
   Maybe there's a better way to do this? I Google'd a bit, but
   didn't find anything like a package_root_path or similar that I
   could pass to the setup function.

2. None of the C or C++ code is used/compiled/installed. I decided
   not to worry about this for now, though thinking about it more it
   probably would be a good idea to install libsubunit.so.

3. I didn't find a version number so I chose 0.0.1 arbitrarily.

I've built python-subunit packages using this code. They are
available in my PPA at:

https://edge.launchpad.net/~jkakar/+archive/ppa

I've installed the hardy package and verified that 'import subunit'
works in a Python interpreter. Anyway, if the packages built by
this branch are acceptable I'd like to rebuild and distribute them
in a subunit-focused PPA.

« Back to merge proposal