Merge lp:~jkakar/subunit/ppa-build into lp:~subunit/subunit/trunk

Proposed by Jamu Kakar
Status: Rejected
Rejected by: Robert Collins
Proposed branch: lp:~jkakar/subunit/ppa-build
Merge into: lp:~subunit/subunit/trunk
Diff against target: None lines
To merge this branch: bzr merge lp:~jkakar/subunit/ppa-build
Reviewer Review Type Date Requested Status
Robert Collins Needs Fixing
Jelmer Vernooij Disapprove
Review via email: mp+5037@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jamu Kakar (jkakar) wrote :

This branch adds a debian/ directory to subunit with Debian
packaging files. It's setup to build the python-subunit package for
multiple versions of Ubuntu with AutoPPA.

Some things that might need improvement:

1. In the end I had to symlink python/subunit to subunit, so that
   setuptools could find the package (this happens in setup.py).
   Maybe there's a better way to do this? I Google'd a bit, but
   didn't find anything like a package_root_path or similar that I
   could pass to the setup function.

2. None of the C or C++ code is used/compiled/installed. I decided
   not to worry about this for now, though thinking about it more it
   probably would be a good idea to install libsubunit.so.

3. I didn't find a version number so I chose 0.0.1 arbitrarily.

I've built python-subunit packages using this code. They are
available in my PPA at:

https://edge.launchpad.net/~jkakar/+archive/ppa

I've installed the hardy package and verified that 'import subunit'
works in a Python interpreter. Anyway, if the packages built by
this branch are acceptable I'd like to rebuild and distribute them
in a subunit-focused PPA.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Jamu Kakar wrote:
> Jamu Kakar has proposed merging lp:~jkakar/subunit/ppa-build into
> lp:subunit.
>
> Requested reviews: Subunit Developers (subunit)
>
> This branch adds a debian/ directory to subunit with Debian
> packaging files. It's setup to build the python-subunit package
> for multiple versions of Ubuntu with AutoPPA.
>
Thanks for PPA-packaging subunit; I don't think distro-specific
packaging like this belongs in the main branch though - Subunit is not
a native package.

vote reject

Cheers,

Jelmer

Revision history for this message
Jelmer Vernooij (jelmer) :
review: Abstain
Revision history for this message
Jelmer Vernooij (jelmer) :
review: Disapprove
Revision history for this message
Robert Collins (lifeless) wrote :

> This branch adds a debian/ directory to subunit with Debian
> packaging files. It's setup to build the python-subunit package for
> multiple versions of Ubuntu with AutoPPA.
>
> Some things that might need improvement:
>
> 1. In the end I had to symlink python/subunit to subunit, so that
> setuptools could find the package (this happens in setup.py).
> Maybe there's a better way to do this? I Google'd a bit, but
> didn't find anything like a package_root_path or similar that I
> could pass to the setup function.

package_dir = {'':python}

but distutils is heinous for non-python, and subunit is only partially python, which is why it doesn't use a setup.py.
...
> I've installed the hardy package and verified that 'import subunit'
> works in a Python interpreter. Anyway, if the packages built by
> this branch are acceptable I'd like to rebuild and distribute them
> in a subunit-focused PPA.

You're welcome to do that - in fact, if you join the subunit developers team you can use the subunit ppa. I've done somewhat more comprehensive packaging for subunit now though - so this branch is rather stale. We could do with more uploads etc :) I'm sorry that the effort you put in wasn't directly used.

review: Needs Fixing

Unmerged revisions

66. By Jamu Kakar

- Fix rules file.

65. By Jamu Kakar

- Moved setup.py back to the root directory and updated it to use a
  symlink to point to subunit.

64. By Jamu Kakar

- Fix broken path in rules file.

63. By Jamu Kakar

- Move setup.py into the python directory so that setuptools can
  find the subunit package.

62. By Jamu Kakar

- Added Debian packaging files and a setuptools setup.py file.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory 'debian'
=== added file 'debian/changelog'
--- debian/changelog 1970-01-01 00:00:00 +0000
+++ debian/changelog 2009-03-30 02:50:56 +0000
@@ -0,0 +1,5 @@
1subunit (0.0.0~trunk) feisty; urgency=low
2
3 * New upstream release.
4
5 -- Jamshed Kakar <jkakar@kakar.ca> Sun, 29 Mar 2009 19:47:00 -0700
06
=== added file 'debian/compat'
--- debian/compat 1970-01-01 00:00:00 +0000
+++ debian/compat 2009-03-30 02:50:56 +0000
@@ -0,0 +1,1 @@
15
02
=== added file 'debian/control'
--- debian/control 1970-01-01 00:00:00 +0000
+++ debian/control 2009-03-30 02:50:56 +0000
@@ -0,0 +1,16 @@
1Source: subunit
2Section: universe/devel
3Priority: optional
4Maintainer: Jamshed Kakar <jkakar@kakar.ca>
5Build-Depends: debhelper, python-central, lsb-release
6Standards-Version: 3.7.2
7XS-Python-Version: current
8
9Package: python-subunit
10Architecture: any
11Depends: ${python:Depends}, ${shlibs:Depends}
12Provides: ${python:Provides}
13XB-Python-Version: ${python:Versions}
14Description: Subunit is attempting to extend unittest with a clean
15 and simple api to run arbitrary external test suites and return the
16 results to standard Python unittest.
017
=== added file 'debian/control.autoppa'
--- debian/control.autoppa 1970-01-01 00:00:00 +0000
+++ debian/control.autoppa 2009-03-30 02:50:56 +0000
@@ -0,0 +1,17 @@
1Source: subunit
2Section: universe/devel
3Priority: optional
4Maintainer: Jamshed Kakar <jkakar@kakar.ca>
5AUTOPPA_INCLUDE(dapper):Build-Depends: debhelper, python-support, python2.4-dev, lsb-release
6AUTOPPA_INCLUDE(hardy,intrepid,jaunty):Build-Depends: debhelper, python-central, python-dev, lsb-release
7Standards-Version: 3.7.2
8XS-Python-Version: current
9
10Package: python-subunit
11Architecture: any
12Depends: ${python:Depends}, ${shlibs:Depends}
13Provides: ${python:Provides}
14XB-Python-Version: ${python:Versions}
15Description: Subunit is attempting to extend unittest with a clean
16 and simple api to run arbitrary external test suites and return the
17 results to standard Python unittest.
018
=== added file 'debian/copyright'
--- debian/copyright 1970-01-01 00:00:00 +0000
+++ debian/copyright 2009-03-30 02:50:56 +0000
@@ -0,0 +1,10 @@
1Copyright:
2
3 Copyright (C) 2005 Robert Collins <robertc@robertcollins.net>
4
5License:
6
7 GPL
8
9On Ubuntu systems, the complete text of the GNU General Public
10License is in `/usr/share/common-licenses/GPL'.
011
=== added file 'debian/rules'
--- debian/rules 1970-01-01 00:00:00 +0000
+++ debian/rules 2009-03-30 06:53:18 +0000
@@ -0,0 +1,55 @@
1#!/usr/bin/make -f
2
3dist_release := $(shell lsb_release -cs)
4ifneq ($(dist_release),dapper)
5 use_pycentral = yes
6endif
7
8package = python-subunit
9root_dir = debian/$(package)
10
11build: build-stamp
12build-stamp:
13 dh_testdir
14 python setup.py build
15 touch build-stamp
16
17clean:
18 dh_testdir
19 dh_testroot
20 rm -f build-stamp
21 rm -rf build
22 dh_clean
23
24install: build
25 dh_testdir
26 dh_testroot
27 dh_clean -k
28 python setup.py install --root $(root_dir)
29
30binary-indep: build install
31
32binary-arch: build install
33 dh_testdir
34 dh_testroot
35 dh_installdocs
36 dh_installchangelogs
37 dh_installinit
38 dh_installdebconf
39 dh_installlogrotate
40 dh_compress
41 dh_fixperms
42
43ifeq ($(use_pycentral),yes)
44 DH_PYCENTRAL=nomove dh_pycentral
45else
46 dh_python
47endif
48 dh_installdeb
49 dh_gencontrol
50 dh_md5sums
51 dh_builddeb
52
53binary: binary-indep binary-arch
54
55.PHONY: binary binary-arch binary-indep clean
056
=== added file 'setup.py'
--- setup.py 1970-01-01 00:00:00 +0000
+++ setup.py 2009-03-30 06:41:16 +0000
@@ -0,0 +1,37 @@
1#!/usr/bin/env python
2import os
3import re
4
5try:
6 from setuptools import setup, Extension
7except ImportError:
8 from distutils.core import setup, Extension
9
10
11if os.path.isfile("MANIFEST"):
12 os.unlink("MANIFEST")
13
14assert not os.path.exists("subunit")
15os.symlink("python/subunit", "subunit")
16try:
17 setup(
18 name="subunit",
19 version="0.0.1",
20 description=("Extensions to Python unittest to get test results "
21 "from subprocesses."),
22 author="Robert Collins",
23 author_email="robertc@robertcollins.net",
24 license="GPL",
25 url="https://launchpad.net/subunit",
26 packages=["subunit"],
27 zip_safe=False,
28 classifiers=[
29 "Development Status :: 4 - Beta",
30 "Intended Audience :: Developers",
31 "License :: OSI Approved :: GNU General Public License (GPL)",
32 "Programming Language :: Python",
33 "Topic :: Software Development :: Libraries :: Python Modules",
34 ],
35 )
36finally:
37 os.unlink("subunit")

Subscribers

People subscribed via source and target branches